Skip to content

test: move test-cli-syntax to sequential - #24907

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mv-flaky
Closed

test: move test-cli-syntax to sequential#24907
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mv-flaky

Conversation

@Trott

@TrottTrott commented Dec 8, 2018

Copy link
Copy Markdown
Member

It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.

Refs: #24403

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: nodejs#24403
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 8, 2018
@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

Assuming green CI, I'd like to fast-track this. Collaborators, please 👍 here for fast-tracking.

@TrottTrott added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 8, 2018
@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

/ping @joyeecheung@targos on the fast-track request above

@addaleax

Copy link
Copy Markdown
Member

Fwiw, I would prefer to mark this as a flaky test…? Moving to sequential is not a solution, and making the failures appear less often is also not a good thing imo…

@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

Fwiw, I would prefer to mark this as a flaky test…? Moving to sequential is not a solution, and making the failures appear less often is also not a good thing imo…

I see what you're saying for sure. IMO it fails so frequently that marking it flaky will likely turn our CI more-or-less permanently yellow, which will make us start ignoring flaky tests completely. I'd rather have it less frequently show up as red so at least we take note when it fails. Regardless, the issue for this should definitely remain open until this is sorted out. (I included Refs: and not Fixes:, which you probably noticed.)

@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19330/

The AIX failure was still this test. 😱

@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

AIX again. I'm alarmed that moving to sequential doesn't help AIX much it seems.

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19331/

@joyeecheung

Copy link
Copy Markdown
Member

Maybe moving it to sequential and mark it as flaky? If it still shows up in AIX that much..

@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

It's green this time. If it continues to fail more than it succeeds on AIX, we can mark it flaky.

@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in 5011dfe

@TrottTrott closed this Dec 8, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2018
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: nodejs#24403
PR-URL: nodejs#24907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: #24403
PR-URL: #24907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: nodejs#24403
PR-URL: nodejs#24907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: #24403
PR-URL: #24907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: #24403
PR-URL: #24907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
It is unreliable under load and the CI failures are getting a bit out of
hand. Let's move it to sequential.
Refs: #24403
PR-URL: #24907
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Trott deleted the mv-flaky branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@addaleax@joyeecheung@targos@cjihrig@BethGriggs