src: use Local version of ToBoolean()

[cjihrig]

This fixes a deprecation warning.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1878/pipeline

[targos]

Isn't this removing a check? I'm not familiar with this code but it removes something about a boolean expected?

[cjihrig]

I don't think so. The compiler warning is:

warning: 'ToBoolean' is deprecated: ToBoolean can never throw. Use Local version.

And, the CHECK_TO_TYPE macro that this previously expanded to does have some additional argument checks, but those exact checks are already present in napi_coerce_to_bool() (the function being modified).

[addaleax]

@targos I’m not sure which check you’re referring to – CHECK_MAYBE_EMPTY? The reason that the Maybe<> variant of ToBoolean() is deprecated that the conversion can never actually fail, so I think that part is okay?

[targos]

It's just that I see napi_boolean_expected in the old code. It looks like some kind of error that was returned if a non-boolean was passed? I'm on mobile so I'm probably missing a lot of context. If that "error" couldn't be triggered before, it LGTM.

[addaleax]

@targosnapi_boolean_expected was the status argument of CHECK_TO_TYPE, which in turn was only used for CHECK_MAYBE_EMPTY, so yes, I think we’re good here.

[danbev]

CI: https://ci.nodejs.org/job/node-test-pull-request/19377/

[cjihrig]

Yellow resume CI: https://ci.nodejs.org/job/node-test-commit/24194/