Skip to content

module: use validateString in modules/esm - #24868

Closed
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:validator-string-esm
Closed

module: use validateString in modules/esm#24868
ZYSzys wants to merge 1 commit into
nodejs:masterfrom
zys-contrib:validator-string-esm

Conversation

@ZYSzys

@ZYSzysZYSzys commented Dec 6, 2018

Copy link
Copy Markdown
Member

Almost same as #24863 :)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@trivikr

trivikr commented Dec 8, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19319/

@trivikrtrivikr added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 8, 2018
@Trott

Trott commented Dec 8, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19336/

@Trott

Trott commented Dec 9, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19343/

@ZYSzys

ZYSzys commented Dec 9, 2018

Copy link
Copy Markdown
MemberAuthor

@Trott It seems to be failed again.😅 Wondering what can I do for it ?

@Trott

Trott commented Dec 9, 2018

Copy link
Copy Markdown
Member

Yeah, turns out failures are likely relevant. Bug in this PR perhaps?

@TrottTrott removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 9, 2018
@BridgeAR

BridgeAR commented Dec 10, 2018•
edited by Trott
Loading

Copy link
Copy Markdown
Member

@Trott the failure looks unrelated to me. The failures from the CI runs also differ, so it's another indicator that it's unrelated. The code change seems to be fine and the functionality should also be identical to the one before.

Resumed CI https://ci.nodejs.org/job/node-test-commit/24157/ ✔️

@Trott

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member

@Trott the failure looks unrelated to me. The failures from the CI runs also differ, so it's another indicator that it's unrelated.

Failure on ARM w/gcc 6 was identical in both runs and appears to be related to module loading, so seems likely related to this PR. But yes, I could be wrong.

Refs: https://ci.nodejs.org/job/node-test-commit-arm/20651/
Refs: https://ci.nodejs.org/job/node-test-commit-arm/20647/

@Trott

Trott commented Dec 10, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Resume Build was successful, so I guess we're good. Although just to be sure...

ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20687/ 😞
ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20688/ ✔️
ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20689/ 😞

(I expect those will pass, but given the current state of CI, I'm also keen to take extra care that we don't introduce another unreliable test. test-cli-syntax has been brutal....)

Argh, looks like this test is already flaky...

@TrottTrott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Dec 10, 2018
@Trott

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member

Maybe it's already flaky? Let's try the same thing, but on master branch:

ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20690/
ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20691/
ARM CI: https://ci.nodejs.org/job/node-test-commit-arm/20692/

@Trott

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member

Oh, yeah, already flaky. Here it is failing for #24924: https://ci.nodejs.org/job/node-test-commit-arm/20670/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 10, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 10, 2018
@ZYSzys@Trott
module: use validateString in modules/esm
d695a01
PR-URL: nodejs#24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@Trott

Trott commented Dec 10, 2018

Copy link
Copy Markdown
Member

Landed in d695a01.

(Sorry for causing an unnecessary delay on landing this.)

@TrottTrott closed this Dec 10, 2018
@ZYSzys
ZYSzys deleted the validator-string-esm branch December 11, 2018 08:48
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
@ZYSzys@BethGriggs
module: use validateString in modules/esm
25dae6c
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelopbeevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@ZYSzys@refack
module: use validateString in modules/esm
512d3fb
PR-URL: nodejs#24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@ZYSzys@BethGriggs
module: use validateString in modules/esm
f2287c6
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@ZYSzys@BethGriggs
module: use validateString in modules/esm
2605b6c
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@ZYSzys@rvagg
module: use validateString in modules/esm
f59c435
PR-URL: #24868
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZYSzys@trivikr@Trott@BridgeAR@lpinca@BethGriggs