Skip to content

querystring: remove eslint-disable - #24995

Merged
cjihrig merged 2 commits into
nodejs:masterfrom
cjihrig:lint
Dec 14, 2018
Merged

querystring: remove eslint-disable#24995
cjihrig merged 2 commits into
nodejs:masterfrom
cjihrig:lint

Conversation

@cjihrig

@cjihrigcjihrig commented Dec 12, 2018

Copy link
Copy Markdown
Contributor

Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Dec 12, 2018

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1913/pipeline

@nodejs-github-botnodejs-github-bot added the querystring Issues and PRs related to the built-in querystring module. label Dec 12, 2018
@Trott

Trott commented Dec 12, 2018

Copy link
Copy Markdown
Member

Is this worth benchmarking?

@targos

targos commented Dec 12, 2018

Copy link
Copy Markdown
Member

I'd say no. Performance can only be improved by this change

@antsmartianantsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2018
@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19532/

@cjihrig

cjihrig commented Dec 14, 2018

Copy link
Copy Markdown
ContributorAuthor

Yellow CI: https://ci.nodejs.org/job/node-test-pull-request/19530/

@cjihrig
querystring: remove eslint-disable
034ec64
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.
PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@cjihrig
url: remove an eslint-disable comment
8ac6c05
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.
PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@cjihrig
cjihrig merged commit 8ac6c05 into nodejs:masterDec 14, 2018
@cjihrig
cjihrig deleted the lint branch December 14, 2018 18:16
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@cjihrig@BethGriggs
url: remove an eslint-disable comment
e7b77ea
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@cjihrig@BethGriggs
querystring: remove eslint-disable
2e94f3b
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelopbeevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig@refack
querystring: remove eslint-disable
cabdccb
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.
PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig@refack
url: remove an eslint-disable comment
d897314
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.
PR-URL: nodejs#24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@cjihrig@BethGriggs
url: remove an eslint-disable comment
b3932ef
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@cjihrig@BethGriggs
url: remove an eslint-disable comment
75ddc04
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig@rvagg
url: remove an eslint-disable comment
3aff725
Remove an eslint-disable comment by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 17, 2019
@cjihrig@BethGriggs
querystring: remove eslint-disable
d3bfdcb
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 28, 2019
@cjihrig@BethGriggs
querystring: remove eslint-disable
8e56a12
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
MylesBorins pushed a commit that referenced this pull request May 16, 2019
@cjihrig@MylesBorins
querystring: remove eslint-disable
45481bc
Remove the eslint-disable comments by using a strict comparison
instead of a Boolean cast.
PR-URL: #24995
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@antsmartianantsmartianantsmartian approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.querystringIssues and PRs related to the built-in querystring module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@cjihrig@nodejs-github-bot@Trott@targos@ChALkeR@antsmartian@BridgeAR@BethGriggs