Skip to content

test: use global.gc() instead of gc() - #25012

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:gc
Dec 15, 2018
Merged

test: use global.gc() instead of gc()#25012
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:gc

Conversation

@cjihrig

@cjihrigcjihrig commented Dec 13, 2018

Copy link
Copy Markdown
Contributor

This change is made for consistency, and to remove an eslint-disable comment.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Dec 13, 2018

Copy link
Copy Markdown
Collaborator

@cjihrig build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1923/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Dec 13, 2018
ChALkeR
ChALkeR approved these changes Dec 13, 2018
View reviewed changes

@ChALkeRChALkeR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be the only place in tests/benchmarks.

LGTM.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2018
@BridgeAR

BridgeAR commented Dec 13, 2018

Copy link
Copy Markdown
Member

I believe the lite CI is enough here.

@Trott

Trott commented Dec 13, 2018•
edited
Loading

Copy link
Copy Markdown
Member

I believe the lite CI is enough here.

I'd prefer we not try to make those judgments. If executable code is changed, CI should be run.

@Trott

Trott commented Dec 13, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/19490/

@Trott

Trott commented Dec 15, 2018•
edited
Loading

Copy link
Copy Markdown
Member

Now that a few more tests are marked flaky, lets' try another CI: https://ci.nodejs.org/job/node-test-pull-request/19550/

@cjihrig

cjihrig commented Dec 15, 2018

Copy link
Copy Markdown
ContributorAuthor

Green CI: https://ci.nodejs.org/job/node-test-pull-request/19549/

@cjihrig
test: use global.gc() instead of gc()
715e3c6
This change is made for consistency, and to remove an
eslint-disable comment.
PR-URL: nodejs#25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@cjihrig
cjihrig merged commit 715e3c6 into nodejs:masterDec 15, 2018
@cjihrig
cjihrig deleted the gc branch December 15, 2018 17:09
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@cjihrig@BethGriggs
test: use global.gc() instead of gc()
ab1801b
This change is made for consistency, and to remove an
eslint-disable comment.
PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelopbeevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@cjihrig@refack
test: use global.gc() instead of gc()
f843f9c
This change is made for consistency, and to remove an
eslint-disable comment.
PR-URL: nodejs#25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@cjihrig@BethGriggs
test: use global.gc() instead of gc()
c9b0a36
This change is made for consistency, and to remove an
eslint-disable comment.
PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@cjihrig@BethGriggs
test: use global.gc() instead of gc()
d50330a
This change is made for consistency, and to remove an
eslint-disable comment.
PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@cjihrig@rvagg
test: use global.gc() instead of gc()
5ff8aeb
This change is made for consistency, and to remove an
eslint-disable comment.
PR-URL: #25012
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChALkeRChALkeRChALkeR approved these changes
@TrottTrottTrott approved these changes
@lpincalpincalpinca approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+1 more reviewer
@Fishrock123Fishrock123Fishrock123 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@cjihrig@nodejs-github-bot@BridgeAR@Trott@ChALkeR@Fishrock123@lpinca@richardlau@BethGriggs