Skip to content

test: mark test-child-process-execsync flaky on AIX - #25031

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:aix-flaky-execsync
Closed

test: mark test-child-process-execsync flaky on AIX#25031
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:aix-flaky-execsync

Conversation

@Trott

@TrottTrott commented Dec 14, 2018

Copy link
Copy Markdown
Member

Contributors, please 👍 here to fast-track.

Refs: #24921

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@TrottTrott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. aix Issues and PRs related to the AIX platform. flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Dec 14, 2018
@nodejs-github-bot

nodejs-github-bot commented Dec 14, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1941/pipeline

@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/19506/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 14, 2018
@Trott

Trott commented Dec 14, 2018•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

Windows CI Rebuild: https://ci.nodejs.org/job/node-test-commit-windows-fanned/23280/ ✔️

@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
MemberAuthor

CI is good but this needs one more Collaborator approval to fast-track.

@Trott

Trott commented Dec 14, 2018

Copy link
Copy Markdown
MemberAuthor

Landed in d0c240f

@TrottTrott closed this Dec 14, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 14, 2018
@Trott
test: mark test-child-process-execsync flaky on AIX
d0c240f
Refs: nodejs#24921
PR-URL: nodejs#25031
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Dec 18, 2018
@Trott@BethGriggs
test: mark test-child-process-execsync flaky on AIX
a4ef54a
Refs: #24921
PR-URL: #25031
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Dec 18, 2018
Merged
@beevelopbeevelop mentioned this pull request Dec 18, 2018
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@Trott@refack
test: mark test-child-process-execsync flaky on AIX
54408a2
Refs: nodejs#24921
PR-URL: nodejs#25031
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@Trott@BethGriggs
test: mark test-child-process-execsync flaky on AIX
89b6d1b
Refs: #24921
PR-URL: #25031
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
@Trott@BethGriggs
test: mark test-child-process-execsync flaky on AIX
1b3f1ca
Refs: #24921
PR-URL: #25031
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@Trott@rvagg
test: mark test-child-process-execsync flaky on AIX
15d3d3d
Refs: #24921
PR-URL: #25031
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott
Trott deleted the aix-flaky-execsync branch January 13, 2022 22:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@bmeckbmeckbmeck approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aixIssues and PRs related to the AIX platform.author readyPRs that have at least one approval, no pending requests for changes, and a CI started.child_processIssues and PRs related to the child_process subsystem.fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Trott@nodejs-github-bot@bmeck@cjihrig@richardlau@gireeshpunathil@BethGriggs