Skip to content

deps: upgrade npm to 6.5.0 release version - #25317

Closed
lance wants to merge 1 commit into
nodejs:masterfrom
lance:npm-6.5.0
Closed

deps: upgrade npm to 6.5.0 release version#25317
lance wants to merge 1 commit into
nodejs:masterfrom
lance:npm-6.5.0

Conversation

@lance

@lancelance commented Jan 2, 2019

Copy link
Copy Markdown
Member

Updates npm dependency to be the released version of 6.5.0. The current version in 11.6.0 is a pre-release version.

Fixes: #25311

~/s/node (npm-6.5.0 $>) nvm use 11.6.0
Now using node v11.6.0 (npm v6.5.0-next.0)

Running make test-npm locally as specified in the guide, there are 5 test failures. So this prompted me to check out the v6.5.0 tag of npm/cli and run the build. That produced significantly more errors.

...
total ........................................... 4797/4832
4797 passing (10m)
9 pending
26 failing
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included (see note above)
  • documentation is changed or added (documentation changes in upstream npm only)
  • commit message follows commit guidelines

@lancelance added the npm Issues and PRs related to the npm client dependency or the npm registry. label Jan 2, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@addaleax

Copy link
Copy Markdown
Member

I think this is a duplicate of #25234 ? :)

@lance

lance commented Jan 2, 2019

Copy link
Copy Markdown
MemberAuthor

@addaleax you are right! Rats! Sorry about that. Closing.

@lancelance closed this Jan 2, 2019
@lance

lance commented Jan 2, 2019

Copy link
Copy Markdown
MemberAuthor

At least I learned how to update npm, so it wasn't all for naught.

@lance
lance deleted the npm-6.5.0 branch January 2, 2019 19:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

npmIssues and PRs related to the npm client dependency or the npm registry.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@lance@nodejs-github-bot@addaleax