Skip to content

[v10.x] deps: cherry-pick d9fbfeb from upstream V8 - #25330

Closed
kjin wants to merge 1 commit into
nodejs:v10.x-stagingfrom
kjin:v8-float-d9fbfeb-v10.x
Closed

[v10.x] deps: cherry-pick d9fbfeb from upstream V8#25330
kjin wants to merge 1 commit into
nodejs:v10.x-stagingfrom
kjin:v8-float-d9fbfeb-v10.x

Conversation

@kjin

@kjinkjin commented Jan 3, 2019

Copy link
Copy Markdown
Contributor

Original commit message:

inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}

See: #23886

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 3, 2019
@kjin
kjinforce-pushed the v8-float-d9fbfeb-v10.x branch from 642db97 to 8404c54CompareJanuary 9, 2019 23:48
@ofrobots

Copy link
Copy Markdown
Contributor

@kjin
kjinforce-pushed the v8-float-d9fbfeb-v10.x branch from 8404c54 to e5615a9CompareJanuary 14, 2019 18:41
@kjin

kjin commented Jan 14, 2019

Copy link
Copy Markdown
ContributorAuthor

@ofrobots Seems like the CI failure is an unrelated flake: https://ci.nodejs.org/job/node-test-binary-windows/22973/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/

I've rebased to resolve conflicts in common.gypi.

@ofrobots

Copy link
Copy Markdown
Contributor

The CI looks good to me. @nodejs/backporters this is ready to land.

@ofrobotsofrobots added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2019
@codebytere
codebytereforce-pushed the v10.x-staging branch 3 times, most recently from 2d6e145 to 7840f71CompareJanuary 29, 2019 18:12
@kjin
kjinforce-pushed the v8-float-d9fbfeb-v10.x branch from e5615a9 to 49b3a42CompareJanuary 31, 2019 23:38
@kjin

kjin commented Jan 31, 2019

Copy link
Copy Markdown
ContributorAuthor

@nodejs/backporters -- could we land this please? Thanks!

@ofrobots

Copy link
Copy Markdown
Contributor

@nodejs/release @nodejs/backporters does the policy that only the backport team should be landing fixes on staging branches still make sense? Perhaps that is unnecessary burden on the team, and we should open this ability up to a broader list of collaborators to ensure things don't get stuck. Similarly: #25242.

@richardlau

Copy link
Copy Markdown
Member

@nodejs/release @nodejs/backporters does the policy that only the backport team should be landing fixes on staging branches still make sense? Perhaps that is unnecessary burden on the team, and we should open this ability up to a broader list of collaborators to ensure things don't get stuck. Similarly: #25242.

Discussion over in nodejs/Release#388.

@BethGriggs

Copy link
Copy Markdown
Member

Could we get a review from @nodejs/v8?, then this should land ready for v10.15.2

@ofrobotsofrobots left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

There were also LGTMs on #23886.
EDIT: launched a new CI: https://ci.nodejs.org/job/node-test-pull-request/20566/

Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{nodejs#56095}
@kjin
kjinforce-pushed the v8-float-d9fbfeb-v10.x branch from 4088a6b to a1b134aCompareFebruary 4, 2019 18:48
@kjin

kjin commented Feb 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Force-pushed to edit the commit message once again, seems like quoted commits need to be spaced 4 whitespaces instead of two.

@BethGriggs

BethGriggs commented Feb 5, 2019

Copy link
Copy Markdown
Member

Landed on v10.x-staging in c9a3e40

BethGriggs pushed a commit that referenced this pull request Feb 5, 2019
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}
PR-URL: #25330
@BethGriggsBethGriggs mentioned this pull request Feb 12, 2019
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Original commit message:
inspector: return [[StableObjectId]] as internal property
This property might be useful for fast '===' check.
R=dgozman@chromium.org,yangguo@chromium.org
Bug: none
Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352
Reviewed-on: https://chromium-review.googlesource.com/1226411
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56095}
PR-URL: #25330
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.buildIssues and PRs related to build files or the CI.v8 engineIssues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@kjin@ofrobots@richardlau@BethGriggs@nodejs-github-bot@alexkozy