Skip to content

src: in-source comments and minor TLS cleanups - #25713

Closed
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:tls-cleanups
Closed

src: in-source comments and minor TLS cleanups#25713
sam-github wants to merge 1 commit into
nodejs:masterfrom
sam-github:tls-cleanups

Conversation

@sam-github

@sam-githubsam-github commented Jan 25, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.

  • Rename waiting_new_session_ after is_waiting_new_session(), instead of
    using reverse naming (new_session_wait_).
  • Make TLSWrap::ClearIn() return void, the value is never used.
  • Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
    arguments, remove them from the js wrapper.

This is semver-patch, none of the changes are visible, not even at the binding layer.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 25, 2019

Copy link
Copy Markdown
Collaborator

@sam-github build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2392/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 25, 2019
addaleax
addaleax approved these changes Jan 25, 2019
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@sam-github

sam-github commented Jan 25, 2019

Copy link
Copy Markdown
ContributorAuthor

Fixed the spelling ofNewSessionDoneDb ("Cb") in the commit message, repushed.

mhdawson
mhdawson approved these changes Jan 25, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrigcjihrig mentioned this pull request Jan 25, 2019
Merged
4 tasks
bnoordhuis
bnoordhuis approved these changes Jan 28, 2019
View reviewed changes
Comment threadsrc/node_crypto.cc Outdated
Comment threadsrc/tls_wrap.cc Outdated
Comment threadsrc/tls_wrap.h Outdated
@sam-github
src: in-source comments and minor TLS cleanups
cbdcaea
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
@addaleax

addaleax commented Jan 28, 2019

Copy link
Copy Markdown
Member

Landed in 46c5c33 (CI run was at https://ci.nodejs.org/job/node-test-pull-request/20382/)

pullBot pushed a commit to SimenB/node that referenced this pull request Jan 28, 2019
@sam-github@addaleax
src: in-source comments and minor TLS cleanups
46c5c33
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
PR-URL: nodejs#25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax pushed a commit that referenced this pull request Jan 28, 2019
@sam-github@addaleax
src: in-source comments and minor TLS cleanups
6d9af41
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
PR-URL: #25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@sam-github
sam-github deleted the tls-cleanups branch January 29, 2019 16:26
@sam-github

sam-github commented Jan 29, 2019

Copy link
Copy Markdown
ContributorAuthor

Thanks for landing @addaleax

@targostargos mentioned this pull request Jan 29, 2019
Merged
sam-github added a commit to sam-github/node that referenced this pull request Apr 29, 2019
@sam-github
src: in-source comments and minor TLS cleanups
6b327e5
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
PR-URL: nodejs#25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@addaleaxaddaleax mentioned this pull request May 29, 2019
Closed
4 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request May 30, 2019
@sam-github@addaleax
src: in-source comments and minor TLS cleanups
b800d29
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
PR-URL: nodejs#25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@addaleaxaddaleax mentioned this pull request May 30, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Jul 16, 2019
@sam-github@BethGriggs
src: in-source comments and minor TLS cleanups
6b0d202
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
Backport-PR-URL: #27967
PR-URL: #25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
BethGriggs pushed a commit that referenced this pull request Jul 17, 2019
@sam-github@BethGriggs
src: in-source comments and minor TLS cleanups
b689008
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
Backport-PR-URL: #27967
PR-URL: #25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggsBethGriggs mentioned this pull request Jul 17, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@addaleaxaddaleaxaddaleax approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sam-github@nodejs-github-bot@addaleax@bnoordhuis@mhdawson