Skip to content

v10.16.1 proposal - #28731

Merged
BethGriggs merged 33 commits into
v10.xfrom
v10.16.1-proposal
Jul 31, 2019
Merged

v10.16.1 proposal#28731
BethGriggs merged 33 commits into
v10.xfrom
v10.16.1-proposal

Conversation

@BethGriggs

@BethGriggsBethGriggs commented Jul 17, 2019•
edited
Loading

Copy link
Copy Markdown
Member

2019-07-31, Version 10.16.1 'Dubnium' (LTS), @BethGriggs

Notable changes

  • deps: upgrade openssl sources to 1.1.1c (Sam Roberts) #28212
  • stream: do not unconditionally call \_read() on resume() (Anna Henningsen) #26965
  • worker: fix nullptr deref after MessagePort deser failure (Anna Henningsen) #25076

Commits

ZYSzysand others added 23 commits June 6, 2019 13:59
@ZYSzys@BethGriggs
esm: fix esm load bug
819a647
Fixes: #25482
Backport-PR-URL: #27874
PR-URL: #25491
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95@BethGriggs
test: clearing require cache crashes esm loader
cc3ca08
This test shows the regression introduced in v11.4.0: clearing out the
require.cache crashes node when using the `--experimental-modules` flag.
Refs: #25482
Backport-PR-URL: #27874
PR-URL: #25491
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@hashseed@BethGriggs
deps: cherry-pick 88f8fe1 from upstream V8
8f780e8
Original commit message:
Fix collection iterator preview with deleted entries
We used to assume that we know the remaining entries returned by the
iterator based on the current index. However, that is not accurate,
since entries skipped by the current index could be deleted.
In the new approach, we allocate conservatively and shrink the result.
R=neis@chromium.org
Bug: v8:8433
Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8
Reviewed-on: https://chromium-review.googlesource.com/c/1325966
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57360}
[The backport to v10.x resolves merge conflicts due to a different way
of accessing the “hole” value in V8, different signatures of the
`Handle` constructor and the `Shrink()` method, and neighbouring-line
conflicts in the test file.]
Refs: v8/v8@88f8fe1Fixes: #27882
Backport-PR-URL: #27894
PR-URL: #24514
Refs: #24053
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@targos@BethGriggs
deps: V8: backport f27ac28
609d2b9
Original commit message:
[turbofan] Pin pure unreachable values to effect chain (in rep selection)
Currently, if we lower to a pure computation that is unreachable because
of some runtime check, we just rename it with DeadValue. This is
problematic if the pure computation gets later eliminated - that allows
the DeadValue node float above the check that makes it dead. As we
conservatively lower DeadValues to debug-break (i.e., crash), we
might induce crash where we should not.
With this CL, whenever we lower an impossible effectful node (i.e., with
Type::None) to a pure node in simplified lowering, we insert an
Unreachable node there (pinned to the effect chain) and mark the
impossible node dead (and make it depend on the Unreachable node).
Bug: chromium:910838
Change-Id: I218991c79b9e283a9dd5beb4d3f0c4664be76cb2
Reviewed-on: https://chromium-review.googlesource.com/c/1365274
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58066}
Refs: v8/v8@f27ac28
PR-URL: #28061Fixes: #27107
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@sam-github@BethGriggs
tls: renegotiate should take care of its own state
5ffe047
In the initial version of this test there were two zero-length writes to
force tls state to cycle. The second is not necessary, at least not now,
but the first was. The renegotiate() API should ensure that packet
exchange takes place, not its users, so move the zero-length write into
tls.
See: #14239
See: b1909d3a70f9
Backport-PR-URL: #27938
PR-URL: #25997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Jayasankar-m@BethGriggs
src: elevate v8 namespaces for node_process.cc
08a32fb
Elevate namespace for repeated entities.
Resolved conflicts.
PR-URL: #24578
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Flarna@BethGriggs
async_hooks: avoid double-destroy HTTPParser
65ef26f
Avoid that destroy hook is invoked twice - once via `Parser::Free()`
and once again via `Parser::Reinitialize()` by clearing the async_id
in `EmitDestroy()`.
Partial backport of #27477, a full
backport would require also #25094
which has a dont-land-on-v10.x label on it.
Fixes: #26961
Backport-PR-URL: #27986
PR-URL: #27477
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@maclover7@BethGriggs
src: extract common Bind method
0dee607
`TCPWrap::Bind` and `TCPWrap::Bind6` share a large amount of
functionality, so a common `Bind` was extracted to remove duplication.
Backport-PR-URL: #28222
PR-URL: #22315
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
@addaleax@BethGriggs
worker: fix nullptr deref after MessagePort deser failure
14090b5
This would previously always have crashed when deserializing
a `MessagePort` fails, because there was always at least one
`nullptr` entry in the vector.
PR-URL: #25076
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@addaleax@BethGriggs
src: fulfill Maybe contract in InlineDecoder
a8f78f0
Use an empty/nothing `Maybe<>` to indicate a pending exception.
PR-URL: #25140
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig@BethGriggs
src: fix warning in cares_wrap.cc
b7dbc1c
This commit fixes the following warning:
./src/cares_wrap.cc:1268:5: warning: comparison of integers of
different signs: 'uint32_t' (aka 'unsigned int') and 'int'
[-Wsign-compare]
CHECK_EQ(ret->Length(), a_count + aaaa_count);
PR-URL: #25230
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR@BethGriggs
doc: add missing changes entry
b3d8a1b
The `util.format()` behavior changed recently. Add the changes entry
to document the new BigInt behavior.
PR-URL: #24758
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@joyeecheung@BethGriggs
src: remove internalBinding('config').warningFile
76af23a
Instead use `require('internal/options')` lazily. Also refactor the
call site a bit so that the option is queried only once since it's
synchronous anyway.
PR-URL: #24959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@mcollina@BethGriggs
stream: make _read() be called indefinitely if the user wants so
044e753
Fixes: #26097
PR-URL: #26135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax@BethGriggs
stream: do not unconditionally call _read() on resume()
274b97c
`readable.resume()` calls `.read(0)`, which in turn previously set
`needReadable = true`, and so a subsequent `.read()` call would
call `_read()` even though enough data was already available.
This can lead to elevated memory usage, because calling `_read()`
when enough data is in the readable buffer means that backpressure
is not being honoured.
Fixes: #26957
PR-URL: #26965
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@mcollina@BethGriggs
process: make stdout and stderr emit 'close' on destroy
f34bb96
Fix: #26550
PR-URL: #26691
Fixes: https://github.com/falseFixes: #26550
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleax@BethGriggs
stream: convert existing buffer when calling .setEncoding
f3841c6
Convert already-stored chunks when `.setEncoding()` is called
so that subsequent `data` events will receive decoded strings,
as they expect.
Fixes: #27932
PR-URL: #27936
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@silverwind@BethGriggs
doc: adjust TOC margins
ad588eb
PR-URL: #28075
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@sam-github@BethGriggs
src: in-source comments and minor TLS cleanups
b689008
Renamed some internal C++ methods and properties for consistency, and
commented SSL I/O.
- Rename waiting_new_session_ after is_waiting_new_session(), instead of
using reverse naming (new_session_wait_), and change "waiting" to
"awaiting".
- Make TLSWrap::ClearIn() return void, the value is never used.
- Fix a getTicketKeys() cut-n-paste error. Since it doesn't use the
arguments, remove them from the js wrapper.
- Remove call of setTicketKeys(getTicketKeys()), its a no-op.
Backport-PR-URL: #27967
PR-URL: #25713
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@cjihrig@BethGriggs
src: fix Get() usage in tls_wrap.cc
f9e8e88
Backport-PR-URL: #27967
PR-URL: #24060
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@addaleax@BethGriggs
tls: add CHECK for impossible condition
99dad28
Backport-PR-URL: #27967
PR-URL: #26843
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax@BethGriggs
tls: add debugging to native TLS code
75052ca
Backport-PR-URL: #27967
PR-URL: #26843
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Gabriel Schulhof@BethGriggs
test: clean up build files
35be08a
Files generated by the build process were accidentally included as part
of an earlier commit. This removes them.
PR-URL: #28297
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Jul 17, 2019
@BethGriggs
BethGriggs changed the base branch from master to v10.xJuly 17, 2019 12:30
mhdawson
mhdawson approved these changes Jul 17, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson

mhdawson commented Jul 17, 2019

Copy link
Copy Markdown
Member

@gabrielschulhof were there some N-API backports you thought would be in the next 10.x release?

bnoordhuisand others added 6 commits July 25, 2019 13:55
@bnoordhuis@BethGriggs
test: fix pty test hangs on aix
ada0ed5
Some pty tests persistently hung on the AIX CI buildbots. Fix that by
adding a helper script that properly sets up the pty before spawning
the script under test.
On investigation I discovered that the test runner hung when it tried
to close the slave pty's file descriptor, probably due to a bug in
AIX's pty implementation. I could reproduce it with a short C program.
The test runner also leaked file descriptors to the child process.
I couldn't convince python's `subprocess.Popen()` to do what I wanted
it to do so I opted to move the logic to a helper script that can do
fork/setsid/etc. without having to worry about stomping on state in
tools/test.py.
In the process I also uncovered some bugs in the pty module of the
python distro that ships with macOS 10.14, leading me to reimplement
a sizable chunk of the functionality of that module.
And last but not least, of course there are differences between ptys
on different platforms and the helper script has to paper over that.
Of course.
Really, this commit took me longer to put together than I care to admit.
Caveat emptor: this commit takes the hacky ^D feeding to the slave out
of tools/test.py and puts it in the *.in input files. You can also feed
other control characters to tests, like ^C or ^Z, simply by inserting
them into the corresponding input file. I think that's nice.
Fixes: nodejs/build#1820Fixes: #28489
PR-URL: #28600
Backport-PR-URL: #28826
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@sam-github@BethGriggs
deps: updated openssl upgrade instructions
c59e0c2
Patching the s390 asm rules is no longer required.
See: openssl/openssl#8351
PR-URL: #28212
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@sam-github@BethGriggs
deps: upgrade openssl sources to 1.1.1c
9e62852
This updates all sources in deps/openssl/openssl by:
$ cd deps/openssl/
$ rm -rf openssl
$ tar zxf ~/tmp/openssl-1.1.1c.tar.gz
$ mv openssl-1.1.1c openssl
$ git add --all openssl
$ git commit openssl
PR-URL: #28212
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@sam-github@BethGriggs
deps: update archs files for OpenSSL-1.1.1c
8f5d6cf
After an OpenSSL source update, all the config files need to be regenerated and
comitted by:
$ cd deps/openssl/config
$ make
$ git add deps/openssl/config/archs
$ git add deps/openssl/openssl/crypto/include/internal/bn_conf.h
$ git add deps/openssl/openssl/crypto/include/internal/dso_conf.h
$ git add deps/openssl/openssl/include/openssl/opensslconf.h
$ git commit
PR-URL: #28212
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@Trott@BethGriggs
tools: replace rollup with ncc
4a607fa
Replace rollup + plugins + config file with zeit/ncc package designed to
do the particular task that we're leveraging rollup for but with
zero-ish configuration. (rollup can do a whole lot more, but we're using
a tiny portion of its functionality.)
PR-URL: #24813
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: #28736
@ZYSzys@BethGriggs
test: remove util.inherits() usage
f332265
Backport-PR-URL: #28795
PR-URL: #25245
Refs: #24755
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Hakerh400Hakerh400 mentioned this pull request Jul 26, 2019
Closed
BethGriggs added a commit that referenced this pull request Jul 26, 2019
@BethGriggs
2019-07-30, Version 10.16.1 'Dubnium' (LTS)
2d18f84
Notable changes:
- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)
PR-URL: #28731
@BethGriggs

BethGriggs commented Jul 26, 2019

Copy link
Copy Markdown
MemberAuthor

test-release-candidate: https://ci.nodejs.org/job/node-release-candidate/10/

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@addaleax@BethGriggs
src: handle empty Maybe in uv binding initialize
0339fba
This can fail when terminating a Worker that loads
the `uv` binding at the same time.
Refs: #25061 (comment)Fixes: #25134
PR-URL: #25079
Backport-PR-URL: #28832
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
BethGriggs added a commit that referenced this pull request Jul 30, 2019
@BethGriggs
2019-07-30, Version 10.16.1 'Dubnium' (LTS)
fe32fe8
Notable changes:
- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)
PR-URL: #28731
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jul 31, 2019•
edited by BethGriggs
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/24799/ ✅

@BethGriggs
2019-07-31, Version 10.16.1 'Dubnium' (LTS)
a395299
Notable changes:
- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)
PR-URL: #28731
@BethGriggs
BethGriggs merged commit a395299 into v10.xJul 31, 2019
BethGriggs added a commit that referenced this pull request Jul 31, 2019
@BethGriggs
Working on v10.16.2
f025f85
PR-URL: #28731
BethGriggs added a commit that referenced this pull request Jul 31, 2019
@BethGriggs
2019-07-31, Version 10.16.1 'Dubnium' (LTS)
9d37013
Notable changes:
- **deps**: upgrade openssl sources to 1.1.1c (Sam Roberts) [#28212](#28212)
- **stream**: do not unconditionally call `\_read()` on `resume()` (Anna Henningsen) [#26965](#26965)
- **worker**: fix nullptr deref after MessagePort deser failure (Anna Henningsen) [#25076](#25076)
PR-URL: #28731
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Jul 31, 2019
@BethGriggs
Blog: v10.16.1 release post
0a42b4a
Refs: nodejs/node#28731
@BethGriggsBethGriggs mentioned this pull request Jul 31, 2019
Merged
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Jul 31, 2019
@BethGriggs
Blog: v10.16.1 release post (#2358)
8934916
Refs: nodejs/node#28731
@BethGriggs
BethGriggs deleted the v10.16.1-proposal branch August 6, 2019 22:45
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gengjiawengengjiawengengjiawen approved these changes
@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

20 participants

@BethGriggs@mhdawson@Trott@nodejs-github-bot@gengjiawen@ZYSzys@aduh95@hashseed@targos@sam-github@Jayasankar-m@Flarna@maclover7@addaleax@cjihrig@BridgeAR@joyeecheung@mcollina@silverwind@bnoordhuis