Skip to content

tools: add test-all-suites to Makefile#25799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Trott wants to merge 3 commits into from
Closed

tools: add test-all-suites to Makefile #25799

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1f25b7e
tools: add test-all-suites to Makefile
Trott Jan 29, 2019
d1611c5
fixup! tools: add test-all-suites to Makefile
Trott Jan 29, 2019
c0b6f8d
fixup! fixup! tools: add test-all-suites to Makefile
Trott Jan 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -455,12 +455,16 @@ test-build-js-native-api: all build-js-native-api-tests
test-build-node-api: all build-node-api-tests

.PHONY: test-all
test-all: test-build ## Run everything in test/.
test-all: test-build ## Run default tests with both Debug and Release builds.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release

test-all-valgrind: test-build
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=debug,release --valgrind

.PHONY: test-all-suites
test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites.
$(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/*

@refackrefackFeb 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT We don't need the test/*

@refackrefackFeb 1, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[side note] Could we have a target that is not dependent on anything else?

@TrottTrottFeb 1, 2019

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without test/*, it runs 2413 test for me locally. With it, it runs 2639 tests. I think it's because leaving off test/* means that test.py will skip the suites in its IGNORED_SUITES list.


CI_NATIVE_SUITES ?= addons js-native-api node-api
CI_JS_SUITES ?= default
CI_DOC := doctool
Expand Down