Uh oh!
There was an error while loading. Please reload this page.
tools: add test-all-suites to Makefile - #25799
Closed
Trott wants to merge 3 commits into
Closed
Conversation
There is currently no Makefile target that runs every test suite. This adds one.
Trott
commented
Jan 29, 2019
MemberAuthor
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
addaleax
approved these changes
Jan 30, 2019
Trott
commented
Jan 30, 2019
MemberAuthor
This was referenced Jan 31, 2019
Trott
commented
Jan 31, 2019
MemberAuthor
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20477/ ✅ |
Trott
commented
Jan 31, 2019
MemberAuthor
This could use one more review/approval. @nodejs/build-files |
refack
approved these changes
Feb 1, 2019
| .PHONY: test-all-suites | ||
| test-all-suites: test-build test-js-native-api test-node-api | bench-addons-build ## Run all test suites. | ||
| $(PYTHON) tools/test.py $(PARALLEL_ARGS) --mode=$(BUILDTYPE_LOWER) test/* |
Contributor
There was a problem hiding this comment.
[side note] Could we have a target that is not dependent on anything else?
MemberAuthor
There was a problem hiding this comment.
Without test/*, it runs 2413 test for me locally. With it, it runs 2639 tests. I think it's because leaving off test/* means that test.py will skip the suites in its IGNORED_SUITES list.
Trott
commented
Feb 1, 2019
MemberAuthor
Landed in e1aa943 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Feb 1, 2019
There is currently no Makefile target that runs every test suite. This adds one. PR-URL: nodejs#25799 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
2 tasks
addaleax pushed a commit
that referenced
this pull request
Feb 3, 2019
There is currently no Makefile target that runs every test suite. This adds one. PR-URL: #25799 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is currently no Makefile target that runs every test suite. This
adds one.
Didn't add it to
vcbuild.batbecause I'm not sure if*wildcard works the same way on Windows or not and I don't have Windows to test. Apparently 26 of the 46 targets inMakefiledo not exist invcbuild.batso I suppose this is not a deal-breaker. But we can open a separate issue (and label itgood-first-contribution) to have this added tovcbuild.bat. Or someone can add a commit to this branch to add it if they have Windows and can test their implementation.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes