Uh oh!
There was an error while loading. Please reload this page.
tools: exclude benchmark code from coverage report - #25841
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Jan 31, 2019
MemberAuthor
@bcoe @nodejs/build-files |
richardlau
approved these changes
Jan 31, 2019
cjihrig
approved these changes
Jan 31, 2019
Trott
commented
Jan 31, 2019
MemberAuthor
MemberAuthor
Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/20487/ ✅ |
refack
approved these changes
Feb 1, 2019
Trott
commented
Feb 1, 2019
MemberAuthor
Would like to fast-track since #25799 has landed. Added that to the daily coverage job but now it's going to report benchmark results again until this lands. Rather than roll it back, I'd prefer to get this in quickly. Please 👍 here to approve fast-tracking. @refack@bcoe@cjihrig@mhdawson@richardlau Rebased to fix merge conflict. Post-rebase CI: https://ci.nodejs.org/job/node-test-pull-request/20532/ |
addaleax
approved these changes
Feb 2, 2019
Trott
commented
Feb 2, 2019
MemberAuthor
Re-running the Raspberry Pi's which were canceled: https://ci.nodejs.org/job/node-test-commit-arm-fanned/6185/ |
Trott
commented
Feb 2, 2019
MemberAuthor
Landed in 8198ca0 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Feb 2, 2019
Refs: nodejs/build#1676 (comment) PR-URL: nodejs#25841 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit
that referenced
this pull request
Feb 3, 2019
Refs: nodejs/build#1676 (comment) PR-URL: #25841 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Coe <bencoe@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This was referenced Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/build#1676 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes