Skip to content

test: add arg to narrow http benchmark test - #26101

Merged
refack merged 1 commit into
nodejs:masterfrom
refack:only-one-bench-http-incoming_headers
Feb 15, 2019
Merged

test: add arg to narrow http benchmark test#26101
refack merged 1 commit into
nodejs:masterfrom
refack:only-one-bench-http-incoming_headers

Conversation

@refack

@refackrefack commented Feb 14, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Recent changes (da0dc51) added a new benchmark (benchmark/http/incoming_headers.js) which takes a new arg (headerDuplicates).
This PR passes a value for that arg so that during the sanity test this benchmark will run only once.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Feb 14, 2019

Copy link
Copy Markdown
Collaborator

@refack build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2603/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2019
@refack

refack commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Special CI job: https://ci.nodejs.org/job/node-test-commit-custom-suites/872/

@refackrefack added benchmark Issues and PRs related to the benchmark subsystem. flaky-test Issues and PRs related to the tests with unstable failures on the CI. labels Feb 14, 2019
@refack

refack commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

An alternative could be to rename the new arg to n ¯\(ツ)/¯

@refackrefack added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 14, 2019
@refack

refack commented Feb 14, 2019

Copy link
Copy Markdown
ContributorAuthor

Please 👍 to fast-track since ATM the daily master job is failing

starkwang
starkwang approved these changes Feb 14, 2019
View reviewed changes

@starkwangstarkwang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlaurichardlau mentioned this pull request Feb 14, 2019
Closed
2 tasks
Trott
Trott reviewed Feb 14, 2019
View reviewed changes
Comment threadtest/benchmark/test-benchmark-http.js Outdated

@TrottTrottFeb 14, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you relocate it higher in the list to keep the list in alphabetical order?

@TrottTrottFeb 14, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you relocate it higher in the list to keep the list in alphabetical order?

Argh, never mind, it's already not alphabetical, just mostly alphabetical. Anyway, LGTM, but nit: Would prefer to alphabetize the list.

(Also, agree that n is probably better. The headers aren't duplicates. They're similarly-named.)

@refack
test: add arg to narrow http benchmark test
fe58bef
PR-URL: nodejs#26101
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@refack
refackforce-pushed the only-one-bench-http-incoming_headers branch from 182ec22 to fe58befCompareFebruary 15, 2019 00:10
@refack
refack merged commit fe58bef into nodejs:masterFeb 15, 2019
@refack

refack commented Feb 15, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Fast-tracked with 3 upvotes
image

@Trott I'll make a follow up clean PR.

@refack
refack deleted the only-one-bench-http-incoming_headers branch February 15, 2019 00:14
@refackrefack mentioned this pull request Feb 15, 2019
Merged
4 tasks
@refack

refack commented Feb 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Refactoring PR #26119

targos pushed a commit that referenced this pull request Feb 15, 2019
@refack@targos
test: add arg to narrow http benchmark test
b0220f8
PR-URL: #26101
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
refack added a commit to refack/node that referenced this pull request Feb 18, 2019
@refack
benchmark,test: refactoring
c7b6a22
PR-URL: nodejs#26119
Refs: nodejs#26101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 19, 2019
@refack@addaleax
benchmark,test: refactoring
b50651f
PR-URL: #26119
Refs: #26101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeARBridgeAR mentioned this pull request Feb 26, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@refack@rvagg
test: add arg to narrow http benchmark test
dd60cd6
PR-URL: #26101
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@refack@rvagg
benchmark,test: refactoring
f4955fd
PR-URL: #26119
Refs: #26101
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@starkwangstarkwangstarkwang approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@refack@nodejs-github-bot@Trott@addaleax@cjihrig@starkwang