Skip to content

test: adjust test-benchmark-http for new benchmark - #26107

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-http-benchmark-test
Closed

test: adjust test-benchmark-http for new benchmark#26107
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:fix-http-benchmark-test

Conversation

@Trott

Copy link
Copy Markdown
Member

Fixes test-benchmark-http to accommodate
da0dc51.

Please 👍 here to fast-track. node-daily-master CI will be red until this lands. (Benchmark tests are not run in regular CI.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Fixes test-benchmark-http to accommodate
da0dc51.
@TrottTrott added flaky-test Issues and PRs related to the tests with unstable failures on the CI. fast-track PRs that do not need to wait for 48 hours to land. labels Feb 14, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Feb 14, 2019
@Trott

Copy link
Copy Markdown
MemberAuthor

@richardlau

Copy link
Copy Markdown
Member

Duplicate of #26101?

@Trott

Copy link
Copy Markdown
MemberAuthor

Duplicate of #26101?

Yup. Closing.

@TrottTrott closed this Feb 14, 2019
@Trott
Trott deleted the fix-http-benchmark-test branch January 13, 2022 22:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fast-trackPRs that do not need to wait for 48 hours to land.flaky-testIssues and PRs related to the tests with unstable failures on the CI.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Trott@nodejs-github-bot@richardlau