Skip to content

test: bump test-bootstrap-modules.js limit - #26520

Merged
refack merged 1 commit into
nodejs:masterfrom
joyeecheung:qmt
Mar 8, 2019
Merged

test: bump test-bootstrap-modules.js limit#26520
refack merged 1 commit into
nodejs:masterfrom
joyeecheung:qmt

Conversation

@joyeecheung

@joyeecheungjoyeecheung commented Mar 8, 2019

Copy link
Copy Markdown
Member

Refs: #25594
Fixes: #26528

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 8, 2019
@joyeecheungjoyeecheung added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 8, 2019
@joyeecheung

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21334/
Please thumbs up this reply if you are +1 to fast-track - this unbreaks master.

@devsnekdevsnek left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry about this

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2019
@tniessen

Copy link
Copy Markdown
Member

Fixes: #26528

PR-URL: nodejs#26520Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@refack
refack merged commit 4fe66a3 into nodejs:masterMar 8, 2019
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
PR-URL: nodejs#26520Fixes: nodejs#26528
Refs: nodejs#25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26520Fixes: #26528
Refs: #25594
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants

@joyeecheung@nodejs-github-bot@tniessen@refack@lpinca@cjihrig@richardlau@devsnek@BridgeAR