Uh oh!
There was an error while loading. Please reload this page.
process: refactor global.queueMicrotask() - #26523
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
- Lazy load `async_hooks` in the implementation - Rename `process/next_tick.js` to `process/task_queues.js` and move the implementation of `global.queueMicrotask()` there since these methods are conceptually related to each other. - Move the bindings used by `global.queueMicrotask()` into `node_task_queue.cc` instead of the generic `node_util.cc` - Use `defineOperation` to define `global.queueMicrotask()`
joyeecheung
commented
Mar 8, 2019
MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/21337/ This is sort-of an alternative to #26520 but it's certainly not fast-trackable. |
addaleax
approved these changes
Mar 8, 2019
devsnek
approved these changes
Mar 8, 2019
BridgeAR
approved these changes
Mar 8, 2019
jasnell
approved these changes
Mar 10, 2019
danbev
commented
Mar 11, 2019
Contributor
Landed in 8d669bb. |
danbev pushed a commit
that referenced
this pull request
Mar 11, 2019
- Lazy load `async_hooks` in the implementation - Rename `process/next_tick.js` to `process/task_queues.js` and move the implementation of `global.queueMicrotask()` there since these methods are conceptually related to each other. - Move the bindings used by `global.queueMicrotask()` into `node_task_queue.cc` instead of the generic `node_util.cc` - Use `defineOperation` to define `global.queueMicrotask()` PR-URL: #26523 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
BridgeAR
commented
Mar 13, 2019
Member
This does not land cleanly on v11. It seems to rely on other commits that should be backported first. It might land cleanly after landing the other backport requested PRs. |
targos pushed a commit
that referenced
this pull request
Mar 27, 2019
- Lazy load `async_hooks` in the implementation - Rename `process/next_tick.js` to `process/task_queues.js` and move the implementation of `global.queueMicrotask()` there since these methods are conceptually related to each other. - Move the bindings used by `global.queueMicrotask()` into `node_task_queue.cc` instead of the generic `node_util.cc` - Use `defineOperation` to define `global.queueMicrotask()` PR-URL: #26523 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async_hooksin the implementationprocess/next_tick.jstoprocess/task_queues.jsand move the implementation of
global.queueMicrotask()there since these methods are conceptually related to
each other.
global.queueMicrotask()intonode_task_queue.ccinstead of the genericnode_util.ccdefineOperationto defineglobal.queueMicrotask()Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes