Skip to content

test: fix test case in test-http2-respond-file-304.js - #26565

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:fix-test-http2-304
Closed

test: fix test case in test-http2-respond-file-304.js#26565
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:fix-test-http2-304

Conversation

@gengjiawen

@gengjiawengengjiawen commented Mar 10, 2019

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 10, 2019
BridgeAR
BridgeAR approved these changes Mar 10, 2019
View reviewed changes

@BridgeARBridgeAR left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@BridgeAR

BridgeAR commented Mar 10, 2019

Copy link
Copy Markdown
Member

CI https://ci.nodejs.org/job/node-test-pull-request/21396/

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2019
@BridgeARBridgeAR mentioned this pull request Mar 10, 2019
Closed
4 tasks
richardlau
richardlau approved these changes Mar 10, 2019
View reviewed changes

@richardlaurichardlau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we lint for cases of assert.strictEqual() with only a single argument?

@Trott

Trott commented Mar 10, 2019

Copy link
Copy Markdown
Member

Can we lint for cases of assert.strictEqual() with only a single argument?

I think assert.strictEqual() should throw if there is only one argument. The second argument should be required. But that's a semver-major change, I suppose.

@BridgeAR

BridgeAR commented Mar 10, 2019

Copy link
Copy Markdown
Member

@richardlau I added such rule in #26569.

@Trott I also thought about doing that while writing the eslint rule. I can add the validation instead - I am just not certain if it's accepted as patch or if someone wants to have it as semver-major change.

@Trott

Trott commented Mar 10, 2019

Copy link
Copy Markdown
Member

@BridgeAR I think lint for now and throw later is fine. If we never get around to throwing later, that's OK too.

@danbev

danbev commented Mar 13, 2019

Copy link
Copy Markdown
Contributor

Landed in e6fa50e.

@danbevdanbev closed this Mar 13, 2019
danbev pushed a commit that referenced this pull request Mar 13, 2019
@gengjiawen@danbev
test: fix test case in test-http2-respond-file-304.js
e6fa50e
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 13, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
32853c0
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.
PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen@BridgeAR
test: fix test case in test-http2-respond-file-304.js
3b8c9cd
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
f95e015
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.
PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BridgeARBridgeAR mentioned this pull request Mar 14, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@gengjiawen@BridgeAR
test: fix test case in test-http2-respond-file-304.js
19c8ebd
PR-URL: nodejs#26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit to BridgeAR/node that referenced this pull request Mar 14, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
1057335
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.
PR-URL: nodejs#26569
Refs: nodejs#26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
@gengjiawen@BridgeAR
test: fix test case in test-http2-respond-file-304.js
9e82ee9
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit that referenced this pull request Mar 14, 2019
@BridgeAR
lib,test: improve faulty assert usage detection
1fa5004
This improves our custom eslint rules to detect assertions to detect
assertions with only a single argument and fixes false negatives in
case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.
PR-URL: #26569
Refs: #26565
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
@gengjiawen@BethGriggs
test: fix test case in test-http2-respond-file-304.js
8855395
PR-URL: #26565
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
This was referenced May 29, 2019
Closed
Closed
Closed
This was referenced May 29, 2019
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@gengjiawen@BridgeAR@Trott@danbev@jasnell@lpinca@cjihrig@richardlau@nodejs-github-bot