Uh oh!
There was an error while loading. Please reload this page.
lib,test: improve faulty assert usage detection - #26569
Closed
BridgeAR wants to merge 2 commits into
Closed
Conversation
This improves our custom eslint rules to detect assertions to detect assertions with only a single argument and fixes false negatives in case unary expressions are used. Some rules were extended to also lint our docs and tools and the lib rule was simplified to prohibit most assertion calls.
jasnell
approved these changes
Mar 10, 2019
Trott
reviewed
Mar 10, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott
approved these changes
Mar 10, 2019
Trott
commented
Mar 10, 2019
Member
Added the |
2 tasks
richardlau
approved these changes
Mar 10, 2019
BridgeAR
commented
Mar 13, 2019
MemberAuthor
MemberAuthor
Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21499/ ✅ (besides ARM) |
MemberAuthor
Rebuild ARM https://ci.nodejs.org/job/node-test-commit-arm-fanned/7159/ ✔️ |
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Mar 13, 2019
This improves our custom eslint rules to detect assertions to detect assertions with only a single argument and fixes false negatives in case unary expressions are used. Some rules were extended to also lint our docs and tools and the lib rule was simplified to prohibit most assertion calls. PR-URL: nodejs#26569 Refs: nodejs#26565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR
commented
Mar 13, 2019
MemberAuthor
Landed in 32853c0 🎉 |
BridgeAR added a commit
that referenced
this pull request
Mar 14, 2019
This improves our custom eslint rules to detect assertions to detect assertions with only a single argument and fixes false negatives in case unary expressions are used. Some rules were extended to also lint our docs and tools and the lib rule was simplified to prohibit most assertion calls. PR-URL: #26569 Refs: #26565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit
to BridgeAR/node
that referenced
this pull request
Mar 14, 2019
This improves our custom eslint rules to detect assertions to detect assertions with only a single argument and fixes false negatives in case unary expressions are used. Some rules were extended to also lint our docs and tools and the lib rule was simplified to prohibit most assertion calls. PR-URL: nodejs#26569 Refs: nodejs#26565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BridgeAR added a commit
that referenced
this pull request
Mar 14, 2019
This improves our custom eslint rules to detect assertions to detect assertions with only a single argument and fixes false negatives in case unary expressions are used. Some rules were extended to also lint our docs and tools and the lib rule was simplified to prohibit most assertion calls. PR-URL: #26569 Refs: #26565 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves our custom eslint rules to detect assertions with only
a single argument and fixes false negatives in case unary expressions are used.
Some rules were extended to also lint our docs and tools and the lib
rule was simplified to prohibit most assertion calls.
This should land after #26565 landed (the linter will fail currently).
Refs: #26565
// cc @nodejs/linting
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes