Skip to content

test: fix test-heapdump-worker - #26713

Closed
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:pummel-heapdump-worker
Closed

test: fix test-heapdump-worker#26713
addaleax wants to merge 1 commit into
nodejs:masterfrom
addaleax:pummel-heapdump-worker

Conversation

@addaleax

@addaleaxaddaleax commented Mar 17, 2019

Copy link
Copy Markdown
Member

This test was broken by d35af56.

Refs: #21283
Fixes: #26712

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 17, 2019

Copy link
Copy Markdown
Collaborator

@addaleax build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2941/pipeline

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Mar 17, 2019
@addaleaxaddaleax added worker Issues and PRs related to Worker support. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 17, 2019
@addaleax

addaleax commented Mar 17, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/21608/
Pummel CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/5417/

Please 👍 this comment to approve fast-tracking, it unbreaks a test.

@addaleaxaddaleax mentioned this pull request Mar 17, 2019
Closed
@richardlau

richardlau commented Mar 18, 2019

Copy link
Copy Markdown
Member

Landed in ed60e86.

richardlau pushed a commit that referenced this pull request Mar 18, 2019
@addaleax@richardlau
test: fix test-heapdump-worker
ed60e86
This test was broken by d35af56.
Refs: #21283Fixes: #26712
PR-URL: #26713
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@addaleax@targos
test: fix test-heapdump-worker
6239913
This test was broken by d35af56.
Refs: nodejs#21283Fixes: nodejs#26712
PR-URL: nodejs#26713
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@addaleax@targos
test: fix test-heapdump-worker
c65ff3d
This test was broken by d35af56.
Refs: #21283Fixes: #26712
PR-URL: #26713
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@targostargos mentioned this pull request Mar 27, 2019
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

Assignees

No one assigned

Labels

fast-trackPRs that do not need to wait for 48 hours to land.testIssues and PRs related to the tests.workerIssues and PRs related to Worker support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky pummel/test-heapdump-worker

5 participants

@addaleax@nodejs-github-bot@richardlau@cjihrig@gireeshpunathil