Skip to content

deps: update nghttp2 to 1.37.0 - #26990

Closed
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:deps_nghttp2
Closed

deps: update nghttp2 to 1.37.0#26990
gengjiawen wants to merge 1 commit into
nodejs:masterfrom
gengjiawen:deps_nghttp2

Conversation

@gengjiawen

@gengjiawengengjiawen commented Mar 29, 2019•
edited
Loading

Copy link
Copy Markdown
Member

See https://github.com/nghttp2/nghttp2/releases.

Maybe need to add label semver-minor ?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 29, 2019
@targos

targos commented Mar 31, 2019

Copy link
Copy Markdown
Member

@nodejs/http2

@targostargos added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2019
@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22052/

@mcollinamcollina added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 31, 2019
mcollina
mcollina approved these changes Mar 31, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZYSzys

ZYSzys commented Apr 3, 2019

Copy link
Copy Markdown
Member

Landed in 5c2ee4e 🎉

@ZYSzysZYSzys closed this Apr 3, 2019
ZYSzys pushed a commit that referenced this pull request Apr 3, 2019
@gengjiawen@ZYSzys
deps: update nghttp2 to 1.37.0
5c2ee4e
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 4, 2019
@gengjiawen@BethGriggs
deps: update nghttp2 to 1.37.0
a674006
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@gengjiawen@BethGriggs
deps: update nghttp2 to 1.37.0
247700f
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@gengjiawen@BethGriggs
deps: update nghttp2 to 1.37.0
3e4c03d
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 10, 2019
@BethGriggs
2019-04-10, Version 11.14.0 (Current)
ebfb67a
Notable changes:
- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
[#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
[#26990](#26990)
- dns:
- make dns.promises enumerable (cjihrig)
[#26592](#26592)
- remove dns.promises experimental warning (cjihrig)
[#26592](#26592)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
[#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
[#26544](#26544)
PR-URL: #27163
BethGriggs added a commit that referenced this pull request Apr 11, 2019
@BethGriggs
2019-04-11, Version 11.14.0 (Current)
cd026f8
Notable changes:
- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
[#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
[#26990](#26990)
- dns:
- make dns.promises enumerable (cjihrig)
[#26592](#26592)
- remove dns.promises experimental warning (cjihrig)
[#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
[#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
[#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
[#26544](#26544)
PR-URL: #27163
BethGriggs added a commit that referenced this pull request Apr 11, 2019
@BethGriggs
2019-04-11, Version 11.14.0 (Current)
d424560
Notable changes:
- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
[#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
[#26990](#26990)
- dns:
- make dns.promises enumerable (cjihrig)
[#26592](#26592)
- remove dns.promises experimental warning (cjihrig)
[#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
[#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
[#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
[#26544](#26544)
PR-URL: #27163
@gengjiawen
gengjiawen deleted the deps_nghttp2 branch April 12, 2019 03:16
BethGriggs pushed a commit that referenced this pull request Aug 15, 2019
@gengjiawen@BethGriggs
deps: update nghttp2 to 1.37.0
ab0f2ac
Backport-PR-URL: #29123
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@BethGriggsBethGriggs mentioned this pull request Aug 15, 2019
Merged
BethGriggs pushed a commit that referenced this pull request Aug 15, 2019
@gengjiawen@BethGriggs
deps: update nghttp2 to 1.37.0
0b44733
PR-URL: #26990
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@sam-github

sam-github commented Aug 15, 2019

Copy link
Copy Markdown
Contributor

@nodejs/http2 This was labelled semver-minor, but it isn't clear why.

The underlying nghttp2 (assuming it is using semver) jumped a minor, but that doesn't necessarily get reflected in node.

Is it actually minor?

@BethGriggsBethGriggs mentioned this pull request Aug 15, 2019
Closed
@addaleaxaddaleax removed the semver-minor PRs that contain new features and should be released in the next minor version. label Aug 15, 2019
@addaleax

addaleax commented Aug 15, 2019

Copy link
Copy Markdown
Member

Just removed the label, this isn’t semver-minor for us.

This was referenced Aug 15, 2019
Closed
Merged
andrewhughes101 added a commit to andrewhughes101/node that referenced this pull request Aug 16, 2019
@andrewhughes101
doc: fixup changelog for v10.16.3
30f30e2
Remove (SEMVER-MINOR) label from patch commit. Add link to table.
Refs: nodejs#26990
BethGriggs pushed a commit that referenced this pull request Aug 16, 2019
@andrewhughes101@BethGriggs
doc: fixup changelog for v10.16.3
791409a
Remove (SEMVER-MINOR) label from patch commit. Add link to table.
Refs: #26990
PR-URL: #29159
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
BethGriggs pushed a commit that referenced this pull request Oct 1, 2019
@andrewhughes101@BethGriggs
doc: fixup changelog for v10.16.3
a3eda28
Remove (SEMVER-MINOR) label from patch commit. Add link to table.
Refs: #26990
PR-URL: #29159
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.http2Issues or PRs related to the http2 subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@gengjiawen@targos@nodejs-github-bot@ZYSzys@sam-github@addaleax@mcollina@jasnell