Skip to content

child_process: doc deprecate ChildProcess._channel - #26982

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:depr
Mar 31, 2019
Merged

child_process: doc deprecate ChildProcess._channel#26982
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:depr

Conversation

@cjihrig

@cjihrigcjihrig commented Mar 29, 2019

Copy link
Copy Markdown
Contributor

This was eligible to begin deprecation in Node 8.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Mar 29, 2019

Copy link
Copy Markdown
Collaborator

@cjihrig Sadly, an error occurred when I tried to trigger a build. :(

@nodejs-github-botnodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Mar 29, 2019
vsemozhetbyt
vsemozhetbyt reviewed Mar 29, 2019
View reviewed changes
Comment threaddoc/api/deprecations.md Outdated
@vsemozhetbytvsemozhetbyt added the child_process Issues and PRs related to the child_process subsystem. label Mar 29, 2019
@nodejs-github-bot

nodejs-github-bot commented Mar 30, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22026/

@nodejs-github-bot

nodejs-github-bot commented Mar 31, 2019•
edited by cjihrig
Loading

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22046/

EDIT(cjihrig): CI was green.

@BridgeARBridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 31, 2019
@cjihrig
child_process: doc deprecate ChildProcess._channel
9b70a5c
This was eligible to begin deprecation in Node 8.
PR-URL: nodejs#26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@cjihrig
cjihrig merged commit 9b70a5c into nodejs:masterMar 31, 2019
@cjihrig
cjihrig deleted the depr branch March 31, 2019 15:54
@joyeecheungjoyeecheung mentioned this pull request Apr 2, 2019
Closed
BethGriggs pushed a commit that referenced this pull request Apr 5, 2019
@cjihrig@BethGriggs
child_process: doc deprecate ChildProcess._channel
28e88f3
This was eligible to begin deprecation in Node 8.
PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@cjihrig@BethGriggs
child_process: doc deprecate ChildProcess._channel
cce98cc
This was eligible to begin deprecation in Node 8.
PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Apr 9, 2019
@cjihrig@BethGriggs
child_process: doc deprecate ChildProcess._channel
2396743
This was eligible to begin deprecation in Node 8.
PR-URL: #26982
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Signed-off-by: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@BethGriggsBethGriggs mentioned this pull request Apr 9, 2019
Merged
@richardlaurichardlau mentioned this pull request Apr 9, 2019
Merged
3 tasks
richardlau added a commit to richardlau/node-1 that referenced this pull request Apr 10, 2019
@richardlau
doc: assign missed deprecation code
f1ab837
Refs: nodejs#26982
PR-URL: nodejs#27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@richardlau@BethGriggs
doc: assign missed deprecation code
75e8377
Refs: #26982
PR-URL: #27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
BethGriggs added a commit that referenced this pull request Apr 10, 2019
@BethGriggs
2019-04-10, Version 11.14.0 (Current)
ebfb67a
Notable changes:
- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
[#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
[#26990](#26990)
- dns:
- make dns.promises enumerable (cjihrig)
[#26592](#26592)
- remove dns.promises experimental warning (cjihrig)
[#26592](#26592)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
[#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
[#26544](#26544)
PR-URL: #27163
BethGriggs added a commit that referenced this pull request Apr 11, 2019
@BethGriggs
2019-04-11, Version 11.14.0 (Current)
cd026f8
Notable changes:
- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
[#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
[#26990](#26990)
- dns:
- make dns.promises enumerable (cjihrig)
[#26592](#26592)
- remove dns.promises experimental warning (cjihrig)
[#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
[#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
[#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
[#26544](#26544)
PR-URL: #27163
BethGriggs added a commit that referenced this pull request Apr 11, 2019
@BethGriggs
2019-04-11, Version 11.14.0 (Current)
d424560
Notable changes:
- child_process: doc deprecate ChildProcess.\_channel (cjihrig)
[#26982](#26982)
- deps: update nghttp2 to 1.37.0 (gengjiawen)
[#26990](#26990)
- dns:
- make dns.promises enumerable (cjihrig)
[#26592](#26592)
- remove dns.promises experimental warning (cjihrig)
[#26592](#26592)
- fs: remove experimental warning for fs.promises (Anna Henningsen)
[#26581] (#26581)
- stream: make Symbol.asyncIterator support stable (Matteo Collina)
[#26989](#26989)
- worker: use copy of process.env (Anna Henningsen)
[#26544](#26544)
PR-URL: #27163
@baby636baby636 mentioned this pull request Jul 12, 2023
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+2 more reviewers
@vsemozhetbytvsemozhetbytvsemozhetbyt left review comments
@sam-githubsam-githubsam-github approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.child_processIssues and PRs related to the child_process subsystem.deprecationsIssues and PRs related to deprecations.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig@nodejs-github-bot@sam-github@bnoordhuis@BridgeAR@vsemozhetbyt