Skip to content

build: V8 gyp files fixes - #27148

Closed
refack wants to merge 6 commits into
nodejs:masterfrom
refack:gyp-opt-78
Closed

build: V8 gyp files fixes#27148
refack wants to merge 6 commits into
nodejs:masterfrom
refack:gyp-opt-78

Conversation

@refack

@refackrefack commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

/CC @nodejs/build-files @nodejs/platform-windows @nodejs/v8-update

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. windows Issues and PRs related to the Windows platform. labels Apr 9, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@refackrefack removed the install Issues and PRs related to the installers. label Apr 9, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@refackrefack self-assigned this Apr 9, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@refackrefack added the review wanted PRs that need reviews. label Apr 9, 2019
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@refack

Copy link
Copy Markdown
ContributorAuthor

@nodejs/v8-update @nodejs/platform-windows @nodejs/build-files

This enables building with MSVS2019 (Currently blocked by a bug), and also improves build time by optimizing PCH usage, and better integration with clcache.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell

Copy link
Copy Markdown
Member

There's been no activity on this in over a year and there are conflicts. Closing. Can reopen if someone decides they want to pick it back up.

@jasnelljasnell closed this Jun 19, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.review wantedPRs that need reviews.toolsIssues and PRs related to the tools directory.v8 engineIssues and PRs related to the V8 dependency.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@refack@nodejs-github-bot@jasnell