Skip to content

build: fixes and optimizations in gyp files - #27108

Closed
refack wants to merge 2 commits into
nodejs:masterfrom
refack:gyp-optimization-73
Closed

build: fixes and optimizations in gyp files#27108
refack wants to merge 2 commits into
nodejs:masterfrom
refack:gyp-optimization-73

Conversation

@refack

@refackrefack commented Apr 5, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Move V8 PCH to tools/v8_gypfiles
  • Create new v8_initializers_pch.h
  • Define GTEST_LANG_CXX11 for gtest compatibility with C++17 (TR namespace removed)
  • Include PCH header directory when using PCH
  • De-dup directives in toolchain.gypi and add comments
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3182

@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. install Issues and PRs related to the installers. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Apr 5, 2019
@refackrefack self-assigned this Apr 5, 2019
@refackrefack added the gyp Issues and PRs related to the GYP tool and .gyp build files label Apr 5, 2019
@nodejs-github-bot

nodejs-github-bot commented Apr 5, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22236/

@refack

refack commented Apr 5, 2019

Copy link
Copy Markdown
ContributorAuthor

/CC @nodejs/build-files @nodejs/v8-update

@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22244/

@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22245/

@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22257/

@refack
refackforce-pushed the gyp-optimization-73 branch 4 times, most recently from bb39ecf to ea42d79CompareApril 7, 2019 23:54
richardlau
richardlau reviewed Apr 8, 2019
View reviewed changes
Comment threaddeps/gtest/gtest.gyp Outdated

@richardlaurichardlauApr 8, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://codereview.chromium.org/2174663002/. Maybe we should be bumping our vendored in version of gtest?

@refackrefackApr 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have that in the pipe line.

richardlau
richardlau previously requested changes Apr 8, 2019
View reviewed changes
Comment threadvcbuild.bat Outdated
@refack
refackforce-pushed the gyp-optimization-73 branch from 24ac28b to 0e089b3CompareApril 8, 2019 14:57
@refackrefack mentioned this pull request Apr 8, 2019
Closed
2 tasks
@refack
refackforce-pushed the gyp-optimization-73 branch 4 times, most recently from d161800 to 9b0ac8bCompareApril 8, 2019 21:30
@nodejs-github-bot

nodejs-github-bot commented Apr 8, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22280/

@refack

refack commented Apr 8, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Ping @nodejs/build-files PTAL.
I would really like to have this in for v12
(Only failing test is code-cache/test-code-cache.js)

@refack

refack commented Apr 8, 2019

Copy link
Copy Markdown
ContributorAuthor

Ping @nodejs/v8-update

@joyeecheung

joyeecheung commented Apr 9, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Can you split this into smaller PRs? I can review some of the GYP changes, but can't really sign off on Windows/MSVC spcific changes.

@refack
refackforce-pushed the gyp-optimization-73 branch from 9b0ac8b to 18e465dCompareApril 9, 2019 13:02
@refack
refackforce-pushed the gyp-optimization-73 branch 2 times, most recently from 13a110d to 9b770b3CompareApril 9, 2019 13:30
@refack

refack commented Apr 9, 2019

Copy link
Copy Markdown
ContributorAuthor

Can you split this into smaller PRs?

I moved out the V8 (#27148) and Windows (#27149, #27150) changes.

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22295/

@refack
refack requested a review from joyeecheungApril 9, 2019 13:30
@refackrefack removed install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform. labels Apr 9, 2019
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22306/

@refackrefack added the review wanted PRs that need reviews. label Apr 9, 2019
joyeecheung
joyeecheung reviewed Apr 9, 2019
View reviewed changes
Comment threadnode.gyp Outdated

@joyeecheungjoyeecheungApr 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Um, doesn't this break etw builds? (I am not sure who actually uses this, though, and it's been broken quite often, but it's listed in https://github.com/nodejs/node/blob/master/doc/guides/diagnostic-tooling-support-tiers.md)

@refackrefackApr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code just moved to

node/node.gyp

Line 627 in 380d1a6

[ 'node_use_etw=="true"', {

@refackrefack mentioned this pull request Apr 9, 2019
Merged
3 tasks
@refack
refackforce-pushed the gyp-optimization-73 branch from 63f4c78 to 380d1a6CompareApril 11, 2019 14:55
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/22369/

@refack

refack commented Apr 11, 2019

Copy link
Copy Markdown
ContributorAuthor

@nodejs/build-files PTAL

@BridgeAR
BridgeARforce-pushed the master branch 2 times, most recently from 8ae28ff to 2935f72CompareMay 31, 2020 12:19
@jasnelljasnell added the stalled Issues and PRs that are stalled. label Jun 19, 2020
@jasnell

jasnell commented Jun 19, 2020

Copy link
Copy Markdown
Member

No activity on this is over a year, does not appear to be moving forward. Closing, can reopen if someone wishes to pick it back up

@jasnelljasnell closed this Jun 19, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung left review comments
@richardlaurichardlaurichardlau left review comments

Assignees

@refackrefack

Labels

buildIssues and PRs related to build files or the CI.gypIssues and PRs related to the GYP tool and .gyp build filesreview wantedPRs that need reviews.stalledIssues and PRs that are stalled.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@refack@nodejs-github-bot@joyeecheung@jasnell@richardlau