Skip to content

build,tools: use mkcodecache to add code cache to the binaries - #27161

Merged
refack merged 3 commits into
nodejs:masterfrom
refack:new-mkcodecache
Apr 16, 2019
Merged

build,tools: use mkcodecache to add code cache to the binaries#27161
refack merged 3 commits into
nodejs:masterfrom
refack:new-mkcodecache

Conversation

@refack

@refackrefack commented Apr 9, 2019

Copy link
Copy Markdown
Contributor

Based on #27135
and #27108

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-botnodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Apr 9, 2019
@refackrefack mentioned this pull request Apr 9, 2019
Closed
2 tasks
@refack
refack requested a review from joyeecheungApril 9, 2019 22:09
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejsnodejs deleted a comment from nodejs-github-botApr 9, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@refackrefack added the review wanted PRs that need reviews. label Apr 10, 2019
@refack

refack commented Apr 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Current change-set works on all platforms (except the RPIs), test failures are most probably flakes.

Reviews are welcome.

@refackrefack added build Issues and PRs related to build files or the CI. process Issues and PRs related to the process subsystem. labels Apr 10, 2019
@nodejs-github-bot

This comment has been minimized.

Sign in to view
joyeecheung
joyeecheung approved these changes Apr 12, 2019
View reviewed changes

@joyeecheungjoyeecheung left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Comment threadMakefile Outdated
Comment threadconfigure.py Outdated
joyeecheung
joyeecheung reviewed Apr 13, 2019
View reviewed changes
Comment threadtools/code_cache/cache_builder.cc Outdated
@refack
refackforce-pushed the new-mkcodecache branch 2 times, most recently from 501a151 to 1d2feb7CompareApril 13, 2019 14:49
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@refackrefack added this to the 12.0.0 milestone Apr 16, 2019
This was referenced Apr 17, 2019
Closed
Closed
@refack
refack deleted the new-mkcodecache branch April 22, 2019 14:36
This was referenced Apr 23, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@refackrefack mentioned this pull request Apr 27, 2019
Closed
This was referenced Jan 15, 2020
Open
Merged
Merged
Open
Merged
Merged
Open
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joyeecheungjoyeecheungjoyeecheung approved these changes
@BridgeARBridgeARBridgeAR left review comments

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.lib / srcIssues and PRs related to general changes in the lib or src directory.notable-changePRs with changes that should be highlighted in changelogs.processIssues and PRs related to the process subsystem.

Projects

None yet

Milestone

12.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@refack@nodejs-github-bot@joyeecheung@BridgeAR