Skip to content

doc: assign missed deprecation code - #27164

Merged
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:deprecations
Apr 10, 2019
Merged

doc: assign missed deprecation code#27164
richardlau merged 1 commit into
nodejs:masterfrom
richardlau:deprecations

Conversation

@richardlau

@richardlaurichardlau commented Apr 9, 2019

Copy link
Copy Markdown
Member

Spotted while reviewing the v11.14.0 proposal.

Refs: #26982

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2019

Copy link
Copy Markdown
Collaborator

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3221

@nodejs-github-botnodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Apr 9, 2019
This was referenced Apr 9, 2019
Merged
Closed
@vsemozhetbyt

vsemozhetbyt commented Apr 10, 2019

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

@richardlaurichardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Apr 10, 2019
@richardlau
doc: assign missed deprecation code
f1ab837
Refs: nodejs#26982
PR-URL: nodejs#27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@richardlaurichardlau self-assigned this Apr 10, 2019
@richardlau

richardlau commented Apr 10, 2019

Copy link
Copy Markdown
MemberAuthor

Landed in f1ab837.

@richardlau
richardlau merged commit f1ab837 into nodejs:masterApr 10, 2019
BethGriggs pushed a commit that referenced this pull request Apr 10, 2019
@richardlau@BethGriggs
doc: assign missed deprecation code
75e8377
Refs: #26982
PR-URL: #27164
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@richardlau
richardlau deleted the deprecations branch April 14, 2019 23:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZYSzysZYSzysZYSzys approved these changes
+1 more reviewer
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@richardlaurichardlau

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.deprecationsIssues and PRs related to deprecations.docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@richardlau@nodejs-github-bot@vsemozhetbyt@ZYSzys