Uh oh!
There was an error while loading. Please reload this page.
src: extract common macro to util.h - #27512
Closed
gengjiawen wants to merge 1 commit into
Closed
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
refack
approved these changes
May 1, 2019
refack
reviewed
May 1, 2019
Uh oh!
There was an error while loading. Please reload this page.
cjihrig
approved these changes
May 1, 2019
cjihrig
left a comment
Contributor
There was a problem hiding this comment.
LGTM with comments addressed.
gengjiawenforce-pushed
the
group_path_sep
branch
2 times, most recently
from
May 1, 2019 14:29
5df1eeb to
4c9b6f4Compareaddaleax
approved these changes
May 1, 2019
BridgeAR
commented
May 3, 2019
Member
This needs a rebase. |
gengjiawen
commented
May 3, 2019
MemberAuthor
Done, thanks. |
nodejs-github-bot
commented
May 3, 2019
Collaborator
gengjiawen
commented
May 7, 2019
MemberAuthor
Rebase again due to conflict. |
Trott
approved these changes
May 7, 2019
4 tasks
nodejs-github-bot
commented
May 9, 2019
Collaborator
jasnell
approved these changes
May 10, 2019
Member
Landed in 56ab82e 🎉 |
ZYSzys pushed a commit
that referenced
this pull request
May 11, 2019
PR-URL: #27512 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
May 11, 2019
PR-URL: #27512 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes