Uh oh!
There was an error while loading. Please reload this page.
src: refactor deprecated UVException usage in pipe-wrap.cc - #27562
Closed
gengjiawen wants to merge 1 commit into
Closed
src: refactor deprecated UVException usage in pipe-wrap.cc#27562gengjiawen wants to merge 1 commit into
gengjiawen wants to merge 1 commit into
Conversation
gengjiawen
commented
May 4, 2019
Uh oh!
There was an error while loading. Please reload this page.
addaleax
approved these changes
May 4, 2019
Trott
approved these changes
May 5, 2019
nodejs-github-bot
commented
May 5, 2019
Collaborator
antsmartian
approved these changes
May 5, 2019
cjihrig
approved these changes
May 5, 2019
nodejs-github-bot
commented
May 5, 2019
Collaborator
MemberAuthor
nodejs-github-bot
commented
May 9, 2019
Collaborator
gengjiawen
commented
May 9, 2019
MemberAuthor
@ZYSzys Looks like this one still failed. |
nodejs-github-bot
commented
May 9, 2019
Collaborator
Contributor
Triggered a re-run (resume). |
gengjiawen
commented
May 9, 2019
MemberAuthor
test-http2-client-destroy failed due to #20750. |
nodejs-github-bot
commented
May 10, 2019
Collaborator
ZYSzys
commented
May 10, 2019
Member
Landed in 07e0395 🎉 |
ZYSzys pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #27562 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
May 10, 2019
PR-URL: #27562 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes