Uh oh!
There was an error while loading. Please reload this page.
vm: mark global proxy as side-effect-free - #27523
Closed
addaleax wants to merge 3 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexkozy
approved these changes
May 1, 2019
alexkozy
left a comment
Member
There was a problem hiding this comment.
As long as calling to this NamedPropertyHandler is unobservable from JavaScript world - looks good to me!
addaleax
commented
May 1, 2019
MemberAuthor
@ak239 It doesn’t – it might call into JS, however. Your comment gave me the idea to add a test for when that JS code has a side effect – thanks! |
alexkozy
commented
May 1, 2019
Member
Nice test! As implementer of this side effect free eval in JS - any other calls to JS world should be fine, since they will contain the same side effects check, so getter without side effects should work, even getter that creates temporary objects and modify them will work. |
targos
approved these changes
May 2, 2019
devsnek
approved these changes
May 2, 2019
bnoordhuis
approved these changes
May 2, 2019
cjihrig
approved these changes
May 2, 2019
BridgeAR
approved these changes
May 3, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
May 12, 2019
Collaborator
jasnell
approved these changes
May 12, 2019
addaleax
commented
May 13, 2019
MemberAuthor
Landed in 815b3aa |
addaleax added a commit
that referenced
this pull request
May 13, 2019
Fixes: #27518 PR-URL: #27523 Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit
to addaleax/node
that referenced
this pull request
May 14, 2019
Read-only access to `process.env` does not have side effects. Refs: nodejs#27523
3 tasks
targos pushed a commit
that referenced
this pull request
May 14, 2019
Fixes: #27518 PR-URL: #27523 Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
pullBot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
May 18, 2019
Read-only access to `process.env` does not have side effects. Refs: nodejs#27523 PR-URL: nodejs#27684 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit
that referenced
this pull request
May 18, 2019
Read-only access to `process.env` does not have side effects. Refs: #27523 PR-URL: #27684 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #27518
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes