Uh oh!
There was an error while loading. Please reload this page.
process: mark process.env as side-effect-free - #27684
Closed
addaleax wants to merge 3 commits into
Closed
Conversation
Read-only access to `process.env` does not have side effects. Refs: nodejs#27523
nodejs-github-bot
commented
May 14, 2019
Collaborator
BridgeAR
approved these changes
May 14, 2019
cjihrig
approved these changes
May 14, 2019
Uh oh!
There was an error while loading. Please reload this page.
nodejs-github-bot
commented
May 14, 2019
Collaborator
alexkozy
approved these changes
May 14, 2019
bnoordhuis
approved these changes
May 14, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott
approved these changes
May 14, 2019
nodejs-github-bot
commented
May 14, 2019
Collaborator
nodejs-github-bot
commented
May 17, 2019
Collaborator
TimothyGu
approved these changes
May 17, 2019
nodejs-github-bot
commented
May 17, 2019
Collaborator
ZYSzys
approved these changes
May 18, 2019
ZYSzys
commented
May 18, 2019
Member
Landed in abe8211 . |
pullBot
pushed a commit
to Rachelmorrell/node
that referenced
this pull request
May 18, 2019
Read-only access to `process.env` does not have side effects. Refs: nodejs#27523 PR-URL: nodejs#27684 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit
that referenced
this pull request
May 18, 2019
Read-only access to `process.env` does not have side effects. Refs: #27523 PR-URL: #27684 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only access to
process.envdoes not have side effects.Refs: #27523
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes