Uh oh!
There was an error while loading. Please reload this page.
test: fix flaky test-tls-multiple-cas-as-string - #27569
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
The following error is emitted in a nondeterministic way on the server side socket on macOS: ``` events.js:173 throw er; // Unhandled 'error' event ^ Error: read ECONNRESET at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27) Emitted 'error' event at: at emitErrorNT (internal/streams/destroy.js:91:8) at emitErrorAndCloseNT (internal/streams/destroy.js:59:3) at processTicksAndRejections (internal/process/task_queues.js:84:9) ``` Prevent the error from being emitted by moving the `socket.end()` call to the client. Also, run tests in parallel and use `common.mustCall()`.
nodejs-github-bot
commented
May 5, 2019
Collaborator
lpinca
commented
May 5, 2019
MemberAuthor
Trott
approved these changes
May 5, 2019
nodejs-github-bot
commented
May 5, 2019
Collaborator
sam-github
approved these changes
May 6, 2019
danbev
commented
May 8, 2019
Contributor
Landed in a681d95. |
danbev pushed a commit
that referenced
this pull request
May 8, 2019
The following error is emitted in a nondeterministic way on the server side socket on macOS: ``` events.js:173 throw er; // Unhandled 'error' event ^ Error: read ECONNRESET at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27) Emitted 'error' event at: at emitErrorNT (internal/streams/destroy.js:91:8) at emitErrorAndCloseNT (internal/streams/destroy.js:59:3) at processTicksAndRejections (internal/process/task_queues.js:84:9) ``` Prevent the error from being emitted by moving the `socket.end()` call to the client. Also, run tests in parallel and use `common.mustCall()`. PR-URL: #27569 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
targos pushed a commit
that referenced
this pull request
May 9, 2019
The following error is emitted in a nondeterministic way on the server side socket on macOS: ``` events.js:173 throw er; // Unhandled 'error' event ^ Error: read ECONNRESET at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27) Emitted 'error' event at: at emitErrorNT (internal/streams/destroy.js:91:8) at emitErrorAndCloseNT (internal/streams/destroy.js:59:3) at processTicksAndRejections (internal/process/task_queues.js:84:9) ``` Prevent the error from being emitted by moving the `socket.end()` call to the client. Also, run tests in parallel and use `common.mustCall()`. PR-URL: #27569 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
2 tasks
lpinca added a commit
to lpinca/node
that referenced
this pull request
Aug 15, 2019
Move `socket.end()` to client. Fixes: nodejs#28111 Refs: nodejs#27569
Trott pushed a commit
that referenced
this pull request
Aug 19, 2019
Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit
that referenced
this pull request
Aug 20, 2019
Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following error is emitted in a nondeterministic way on the server
side socket on macOS:
Prevent the error from being emitted by moving the
socket.end()callto the client. Also, run tests in parallel and use
common.mustCall().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes