test: deflake test-tls-passphrase

[lpinca]

Move socket.end() to client.

Fixes: #28111
Refs: #27569

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[lpinca]

$ ./tools/test.py -J --repeat=500 test/parallel/test-tls-passphrase.js === release test-tls-passphrase === Path: parallel/test-tls-passphrase
events.js:186
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event on TLSSocket instance at:
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at processTicksAndRejections (internal/process/task_queues.js:77:11) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
}
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-tls-passphrase.js
=== release test-tls-passphrase === Path: parallel/test-tls-passphrase
events.js:186
throw er; // Unhandled 'error' event
^
Error: read ECONNRESET
at TLSWrap.onStreamRead (internal/stream_base_commons.js:183:27)
Emitted 'error' event on TLSSocket instance at:
at emitErrorNT (internal/streams/destroy.js:91:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:59:3)
at processTicksAndRejections (internal/process/task_queues.js:77:11) {
errno: -54,
code: 'ECONNRESET',
syscall: 'read'
}
Command: out/Release/node /Users/luigi/code/node/test/parallel/test-tls-passphrase.js
...

[lpinca]

cc: @sam-github

[bnoordhuis]

LGTM with a suggestion.

[sam-github]

@lpinca It looks like you are changing it so client ends connection rather than server, to prevent races. Is it still flaky, or not flaky? I'm not sure if the errors you pinged me about were before or after your fix. The changes LGTM

[lpinca]

The error is before fix, it is no longer flaky now unless I raise --repeat to 1000. After that a new errors occurs (EADDRNOTAVAIL) but that is a different issue. See #28337 (comment).

Also it looks this fixes #28111. Will add the "Fixes:" metadata.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/25105/

[Trott]

Landed in a0cc62f