http: ClientRequest.abort is destroy by ronag · Pull Request #28683 · nodejs/node

ronag · 2019-07-14T19:18:36Z

ClientRequest.destroy() should be the same as abort(). Make ClientRequest more streamlike by deprecating abort().

If request has completed it cannot be aborted.

This also allows us to replace a lot of edge case code (e.g. isRequest) that has to call abort for ClientRequest while everything else is just destroy.

Calling destroy previously instead of abort might have some weird behaviour since abort seems to take a lot more stuff into account e.g. req.agent.

Refs: #28686

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

NOTE TO SELF: look into the callback

ronag · 2019-07-15T14:51:36Z

There is more work to be done (e.g. the TODO in this PR) in terms of making ClientRequest and OutgoingMessage more stream like. But I suggest that be done in future PR's.

ronag · 2019-07-15T18:00:48Z

Fixed failing test

ronag · 2019-07-15T18:00:58Z

ping @benjamingr

ronag · 2019-08-09T16:12:37Z

@Trott: This is no longer blocked

nodejs-github-bot · 2019-08-09T18:17:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/24908/

ronag · 2019-08-17T07:36:06Z

@Trott: this looks ready

ronag · 2019-08-17T08:43:10Z

@lpinca you good with this?

lpinca

RSLGTM

lpinca · 2019-08-17T08:57:51Z

I think this requires a CITGM run. The breaking changes are big enough.

ronag · 2019-08-17T08:58:43Z

RSLGTM

lol, what? :D

lpinca · 2019-08-17T08:59:07Z

Rubber Stamp LGTM :)

ronag · 2019-08-17T09:01:01Z

@Trott CITGM please

lpinca · 2019-08-17T09:02:01Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/1953/

Trott · 2019-08-17T14:29:21Z

+Type: Documentation-only
+
+[`ClientRequest.destroy()`][] should be the same as
+[`ClientRequest.abort()`][]. Make ClientRequest more streamlike by deprecating


Optional suggestion:
Suggested change
[`ClientRequest.abort()`][]. Make ClientRequest more streamlike by deprecating
[`ClientRequest.abort()`][]. Make ClientRequest more stream-like by deprecating

Trott · 2019-08-17T14:30:09Z

CITGM looks good but this does need a rebase.

ronag · 2019-08-17T14:54:11Z

@Trott: this is missing deprecation idx (i.e. DEP0XXX) which makes merging harder... 0daec61... is that a mistake?

ronag · 2019-08-18T21:16:35Z

I think #29192 is a much more elegant solution, although a bit more risky...

ronag · 2019-08-20T08:03:07Z

@mcollina, @lpinca (someone else?): unless you have an objection I would prefer to close this PR in favor of #29192.

@Trott: Otherwise, I would like to remove the change where we swallow any error after destroy()/abort() until the conversation in #29197 is resolved.

This PR needs mode thoughts.

ronag · 2019-08-20T09:34:47Z

Closing in favor of #29192 which should not be as controversial. Will open a new PR if required once there is consensus.

nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 14, 2019

ronag force-pushed the http-client-destroy2 branch 4 times, most recently from 7962df1 to cdd194eCompare July 14, 2019 19:27

vsemozhetbyt reviewed Jul 14, 2019
View reviewed changes

Comment threaddoc/api/http.md Outdated

addaleax added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 14, 2019

ronag force-pushed the http-client-destroy2 branch 3 times, most recently from 673aa19 to 6bd3be5Compare July 14, 2019 20:05

addaleax approved these changes Jul 14, 2019
View reviewed changes

Comment threaddoc/api/deprecations.md Outdated
Comment threaddoc/api/deprecations.md Outdated

ronag force-pushed the http-client-destroy2 branch 2 times, most recently from a450164 to 54c460aCompare July 14, 2019 20:24

vsemozhetbyt reviewed Jul 15, 2019
View reviewed changes

Comment threaddoc/api/deprecations.md Outdated

vsemozhetbyt reviewed Jul 15, 2019
View reviewed changes

Comment threaddoc/api/deprecations.md Outdated

vsemozhetbyt reviewed Jul 15, 2019
View reviewed changes

Comment threaddoc/api/http.md Outdated

ronag force-pushed the http-client-destroy2 branch 2 times, most recently from 9f97795 to d0101f8Compare July 15, 2019 14:14

ronag force-pushed the http-client-destroy2 branch from d0101f8 to ab00509Compare July 15, 2019 18:00

lpinca reviewed Jul 15, 2019
View reviewed changes

Comment threadlib/_http_client.js Outdated
Comment threadlib/_http_client.js Outdated

ronag force-pushed the http-client-destroy2 branch 6 times, most recently from 9f8fb09 to 3bbfbdeCompare July 15, 2019 20:22

lpinca reviewed Jul 16, 2019
View reviewed changes

Comment threadlib/_http_client.js Outdated

ronag mentioned this pull request Jul 16, 2019
http: ignore socket errors after req.abort #20077
Closed
4 tasks

Trott mentioned this pull request Jul 17, 2019
http: refactor emit error #28696
Closed
2 tasks

ronag force-pushed the http-client-destroy2 branch from c9baec5 to 3211fe8Compare August 2, 2019 09:55

trivikr requested a review from lpinca August 2, 2019 17:50

ronag mentioned this pull request Aug 6, 2019
http: ClientRequest streamlike #29002
Closed
9 tasks

ronag added 3 commits August 9, 2019 18:08

http: clientRequest.abort is destroy
06a8208

http: fix test where aborted should not be emitted
dfcaf18

http: don't emit error after destroy or multiple times
6f95d70

ronag force-pushed the http-client-destroy2 branch from 3211fe8 to 6f95d70Compare August 9, 2019 16:08

Trott removed the blocked PRs that are blocked by other issues or PRs. label Aug 9, 2019

lpinca approved these changes Aug 17, 2019
View reviewed changes

Trott reviewed Aug 17, 2019
View reviewed changes

ronag mentioned this pull request Aug 18, 2019
[x] http: client destroy stream #29192
Closed
4 tasks

ronag mentioned this pull request Aug 18, 2019
stream: fix multiple destroy() calls #29197
Closed
4 tasks

ronag closed this Aug 20, 2019

	[`ClientRequest.abort()`][]. Make ClientRequest more streamlike by deprecating
	[`ClientRequest.abort()`][]. Make ClientRequest more stream-like by deprecating

Uh oh!

Uh oh!

Conversation

ronag commented Jul 14, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ronag commented Jul 15, 2019

Uh oh!

ronag commented Jul 15, 2019

Uh oh!

ronag commented Jul 15, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ronag commented Aug 9, 2019

Uh oh!

nodejs-github-bot commented Aug 9, 2019

Uh oh!

ronag commented Aug 17, 2019

Uh oh!

ronag commented Aug 17, 2019

Uh oh!

lpinca left a comment

Choose a reason for hiding this comment

Uh oh!

lpinca commented Aug 17, 2019

Uh oh!

ronag commented Aug 17, 2019

Uh oh!

lpinca commented Aug 17, 2019

Uh oh!

ronag commented Aug 17, 2019

Uh oh!

lpinca commented Aug 17, 2019

Uh oh!

TrottAug 17, 2019

Choose a reason for hiding this comment

Uh oh!

Trott commented Aug 17, 2019

Uh oh!

ronag commented Aug 17, 2019

Uh oh!

ronag commented Aug 18, 2019

Uh oh!

ronag commented Aug 20, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronag commented Aug 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ronag commented Jul 14, 2019•
edited
Loading

ronag commented Aug 20, 2019•
edited
Loading