Skip to content

http: refactor emit error - #28696

Closed
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:http-refactor-emit-error
Closed

http: refactor emit error#28696
ronag wants to merge 1 commit into
nodejs:masterfrom
nxtedition:http-refactor-emit-error

Conversation

@ronag

@ronagronag commented Jul 15, 2019

Copy link
Copy Markdown
Member

A small cleanup.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the http Issues or PRs related to the http subsystem. label Jul 15, 2019
lpinca
lpinca reviewed Jul 15, 2019
View reviewed changes
Comment threadlib/_http_client.js Outdated
@ronag
ronagforce-pushed the http-refactor-emit-error branch from d9b0bce to c611d93CompareJuly 15, 2019 12:55
@ronagronag mentioned this pull request Jul 15, 2019
Closed
4 tasks
@ronag

ronag commented Jul 15, 2019

Copy link
Copy Markdown
MemberAuthor

Blocked by #20077

@trivikr

trivikr commented Jul 15, 2019

Copy link
Copy Markdown
Member

Code in PR #20077 landed, this PR can be rebased

@ronag

ronag commented Jul 15, 2019

Copy link
Copy Markdown
MemberAuthor

@trivikr rebased

@ronag
ronagforce-pushed the http-refactor-emit-error branch from c611d93 to 24aead5CompareJuly 15, 2019 20:35
@trivikr

trivikr commented Jul 15, 2019

Copy link
Copy Markdown
Member

I missed comment from @Trott
#20077 was reverted #20077 (comment)

@Trott

Trott commented Jul 17, 2019

Copy link
Copy Markdown
Member

Is this blocked on something still? #28683 perhaps?

@ronag

ronag commented Jul 17, 2019

Copy link
Copy Markdown
MemberAuthor

@Trott I don't think this is relevant anymore due to #28683.

@ronagronag closed this Jul 17, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

httpIssues or PRs related to the http subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ronag@trivikr@Trott@jasnell@addaleax@lpinca@nodejs-github-bot