Skip to content

Fix code example in events API docs - #2896

Closed
dgerber wants to merge 1 commit into
nodejs:masterfrom
dgerber:fix-doc-events
Closed

Fix code example in events API docs#2896
dgerber wants to merge 1 commit into
nodejs:masterfrom
dgerber:fix-doc-events

Conversation

@dgerber

@dgerberdgerber commented Sep 16, 2015

Copy link
Copy Markdown

No description provided.

@brendanashworthbrendanashworth added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. labels Sep 16, 2015
@evanlucas

evanlucas commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

This was actually one of the changes from 0.10. require('events') now returns an EventEmitter

Fishrock123
Fishrock123 reviewed Sep 16, 2015
View reviewed changes
Comment threaddoc/api/events.markdown

@Fishrock123Fishrock123Sep 16, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this line, directly above. This was changed ages ago. :)

@Fishrock123

Fishrock123 commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

Thanks for the contribution though, hopefully you'll find something else to contribute! :)

@dgerber

dgerber commented Sep 16, 2015

Copy link
Copy Markdown
Author

Sorry, still using v0.10...
Then you may want to change that part of the docs which still reads:

const EventEmitter = require('events').EventEmitter;

@evanlucas

evanlucas commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

Yes we probably should. I feel that would be acceptable

@Fishrock123

Fishrock123 commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

@dgerber yes, would you mind to make a PR for that? :)

thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Sep 16, 2015
@thefourtheye
doc: remove usage of events.EventEmitter
990659c
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: nodejs#2896
@thefourtheyethefourtheye mentioned this pull request Sep 16, 2015
Closed
thefourtheye added a commit to thefourtheye/io.js that referenced this pull request Sep 17, 2015
@thefourtheye
lib,src: remove usage of events.EventEmitter
705ff31
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: nodejs#2896
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye
doc: remove usage of events.EventEmitter
7953c83
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye
lib,src: remove usage of events.EventEmitter
f32a606
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye@rvagg
doc: remove usage of events.EventEmitter
43e2b7f
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye@rvagg
lib,src: remove usage of events.EventEmitter
1860e0c
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@s4scs4sc mentioned this pull request Nov 30, 2023
Open
@AyushG3112AyushG3112 mentioned this pull request Nov 30, 2023
Open
@thakursachin467thakursachin467 mentioned this pull request Nov 30, 2023
Open
@erdunerdun mentioned this pull request Nov 30, 2023
Open
@olegnnolegnn mentioned this pull request Nov 30, 2023
Open
@RoeeOrenRoeeOren mentioned this pull request Nov 30, 2023
Open
@GregorFendtGregorFendt mentioned this pull request Nov 30, 2023
Open
@timzwittimzwit mentioned this pull request Nov 30, 2023
Open
@aliceUnhinged613aliceUnhinged613 mentioned this pull request Nov 30, 2023
Open
@soleboxsolebox mentioned this pull request Nov 30, 2023
Open
@RickAllMighty8195RickAllMighty8195 mentioned this pull request Feb 11, 2024
Open
@Megoy-TambayanMegoy-Tambayan mentioned this pull request Feb 11, 2024
Open
@DixiejaneDixiejane mentioned this pull request Feb 11, 2024
Open
@JCsomeShotsJCsomeShots mentioned this pull request Feb 11, 2024
Open
@jj-cryptojj-crypto mentioned this pull request Feb 11, 2024
Open
@ZRDKZRDK mentioned this pull request Feb 11, 2024
Open
@buzzlightyear726buzzlightyear726 mentioned this pull request Feb 11, 2024
Open
@RenukalochRenukaloch mentioned this pull request Feb 11, 2024
Open
@MaxMood96MaxMood96 mentioned this pull request Feb 11, 2024
Open
@davidmatherdavidmather mentioned this pull request Feb 11, 2024
Open
@mrod0101mrod0101 mentioned this pull request Feb 11, 2024
Closed
@CxsLucyferCxsLucyfer mentioned this pull request Feb 11, 2024
Open
@dewaynesmith3711dewaynesmith3711 mentioned this pull request Feb 11, 2024
Open
@kingjay66kingjay66 mentioned this pull request Feb 11, 2024
Open
@zhangpan0907zhangpan0907 mentioned this pull request Feb 11, 2024
Open
@SupermajestcdSupermajestcd mentioned this pull request Feb 12, 2024
Open
@MatheusKaelMatheusKael mentioned this pull request Feb 12, 2024
Open
@SanchitMahajan236SanchitMahajan236 mentioned this pull request Feb 12, 2024
Open
@terrorizer1980terrorizer1980 mentioned this pull request Feb 12, 2024
Open
@myvali998myvali998 mentioned this pull request Feb 12, 2024
Open
@ambaiambai mentioned this pull request Feb 12, 2024
Open
@dewaynesmith3711dewaynesmith3711 mentioned this pull request Feb 12, 2024
Open
@BryanLauraBryanLaura mentioned this pull request Feb 12, 2024
Open
@nicholaschoi168nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@jefeaguilajefeaguila mentioned this pull request Feb 12, 2024
Open
@Michaela813Michaela813 mentioned this pull request Feb 12, 2024
Open
@chrismillerukchrismilleruk mentioned this pull request Feb 12, 2024
Open
@Michaela813Michaela813 mentioned this pull request Feb 12, 2024
Open
@JoanKalanzi1JoanKalanzi1 mentioned this pull request Feb 12, 2024
Open
@BryanLauraBryanLaura mentioned this pull request Feb 12, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dgerber@evanlucas@Fishrock123@brendanashworth