Skip to content

lib,src,doc: remove usage of events.EventEmitter - #2921

Closed
thefourtheye wants to merge 2 commits into
nodejs:masterfrom
thefourtheye:events-eventemitter-usage
Closed

lib,src,doc: remove usage of events.EventEmitter#2921
thefourtheye wants to merge 2 commits into
nodejs:masterfrom
thefourtheye:events-eventemitter-usage

Conversation

@thefourtheye

@thefourtheyethefourtheye commented Sep 16, 2015

Copy link
Copy Markdown
Contributor

The events module already exports EventEmitter constructor function
So, we don't have to use events.EventEmitter to access it.

Refer: #2896

cc @silverwind@evanlucas

@thefourtheye
doc: remove usage of events.EventEmitter
990659c
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: nodejs#2896
@thefourtheyethefourtheye added doc Issues and PRs related to the documentations. events Issues and PRs related to the events subsystem / EventEmitter. test Issues and PRs related to the tests. labels Sep 16, 2015
evanlucas
evanlucas reviewed Sep 17, 2015
View reviewed changes
Comment threadlib/_http_server.js Outdated

@evanlucasevanlucasSep 17, 2015

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe var obj = new EventEmitter();?

@thefourtheyethefourtheyeSep 17, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanlucas I updated this. Thanks :-)

@thefourtheye
lib,src: remove usage of events.EventEmitter
705ff31
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: nodejs#2896
@thefourtheye
thefourtheyeforce-pushed the events-eventemitter-usage branch 2 times, most recently from 742a9ad to 705ff31CompareSeptember 19, 2015 06:47
@thefourtheye

thefourtheye commented Sep 19, 2015

Copy link
Copy Markdown
ContributorAuthor

Removing the test changes, after a lengthy discussion with @brendanashworth ;-)

@thefourtheyethefourtheye removed the test Issues and PRs related to the tests. label Sep 19, 2015
@thefourtheyethefourtheye changed the title lib,src,test,doc: remove usage of events.EventEmitterlib,src,doc: remove usage of events.EventEmitterSep 19, 2015
@silverwind

silverwind commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/361/

@silverwind

silverwind commented Sep 22, 2015

Copy link
Copy Markdown
Contributor

LGTM

1 similar comment
@targos

targos commented Sep 22, 2015

Copy link
Copy Markdown
Member

LGTM

thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye
doc: remove usage of events.EventEmitter
7953c83
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye
lib,src: remove usage of events.EventEmitter
f32a606
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@thefourtheye

thefourtheye commented Sep 22, 2015

Copy link
Copy Markdown
ContributorAuthor

Thanks for the review, landed in f32a606 and 7953c83

@thefourtheye
thefourtheye deleted the events-eventemitter-usage branch September 22, 2015 18:54
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye@rvagg
doc: remove usage of events.EventEmitter
43e2b7f
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
thefourtheye added a commit that referenced this pull request Sep 22, 2015
@thefourtheye@rvagg
lib,src: remove usage of events.EventEmitter
1860e0c
The `events` module already exports `EventEmitter` constructor function
So, we don't have to use `events.EventEmitter` to access it.
Refer: #2896
PR-URL: #2921
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
@rvaggrvagg mentioned this pull request Sep 22, 2015
Merged
@targostargos mentioned this pull request Oct 24, 2015
Closed
stojanovic added a commit to stojanovic/koa that referenced this pull request Oct 24, 2015
@stojanovic
Refactor - EventEmitter is already exported by 'events' module
dac250b
The 'events' module already exports 'EventEmitter' constructor function - nodejs/node#2921
This was referenced Nov 11, 2015
Merged
Merged
@joyeecheungjoyeecheung mentioned this pull request Dec 10, 2016
Closed
2 tasks
@s4scs4sc mentioned this pull request Nov 30, 2023
Open
@AyushG3112AyushG3112 mentioned this pull request Nov 30, 2023
Open
@thakursachin467thakursachin467 mentioned this pull request Nov 30, 2023
Open
@Megoy-TambayanMegoy-Tambayan mentioned this pull request Feb 11, 2024
Open
@DixiejaneDixiejane mentioned this pull request Feb 11, 2024
Open
@JCsomeShotsJCsomeShots mentioned this pull request Feb 11, 2024
Open
@jj-cryptojj-crypto mentioned this pull request Feb 11, 2024
Open
@ZRDKZRDK mentioned this pull request Feb 11, 2024
Open
@buzzlightyear726buzzlightyear726 mentioned this pull request Feb 11, 2024
Open
@RenukalochRenukaloch mentioned this pull request Feb 11, 2024
Open
@MaxMood96MaxMood96 mentioned this pull request Feb 11, 2024
Open
@davidmatherdavidmather mentioned this pull request Feb 11, 2024
Open
@mrod0101mrod0101 mentioned this pull request Feb 11, 2024
Closed
@CxsLucyferCxsLucyfer mentioned this pull request Feb 11, 2024
Open
@dewaynesmith3711dewaynesmith3711 mentioned this pull request Feb 11, 2024
Open
@kingjay66kingjay66 mentioned this pull request Feb 11, 2024
Open
@zhangpan0907zhangpan0907 mentioned this pull request Feb 11, 2024
Open
@SupermajestcdSupermajestcd mentioned this pull request Feb 12, 2024
Open
@MatheusKaelMatheusKael mentioned this pull request Feb 12, 2024
Open
@SanchitMahajan236SanchitMahajan236 mentioned this pull request Feb 12, 2024
Open
@terrorizer1980terrorizer1980 mentioned this pull request Feb 12, 2024
Open
@myvali998myvali998 mentioned this pull request Feb 12, 2024
Open
@ambaiambai mentioned this pull request Feb 12, 2024
Open
@dewaynesmith3711dewaynesmith3711 mentioned this pull request Feb 12, 2024
Open
@BryanLauraBryanLaura mentioned this pull request Feb 12, 2024
Open
@nicholaschoi168nicholaschoi168 mentioned this pull request Feb 12, 2024
Open
@jefeaguilajefeaguila mentioned this pull request Feb 12, 2024
Open
@Michaela813Michaela813 mentioned this pull request Feb 12, 2024
Open
@chrismillerukchrismilleruk mentioned this pull request Feb 12, 2024
Open
@Michaela813Michaela813 mentioned this pull request Feb 12, 2024
Open
@JoanKalanzi1JoanKalanzi1 mentioned this pull request Feb 12, 2024
Open
@BryanLauraBryanLaura mentioned this pull request Feb 12, 2024
Open
truedev0127 added a commit to truedev0127/koa that referenced this pull request Dec 22, 2025
@truedev0127
Refactor - EventEmitter is already exported by 'events' module
78b08eb
The 'events' module already exports 'EventEmitter' constructor function - nodejs/node#2921
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.eventsIssues and PRs related to the events subsystem / EventEmitter.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thefourtheye@silverwind@targos@evanlucas