Skip to content

stream: always invoke end(cb) callback - #29747

Closed
ronag wants to merge 9 commits into
nodejs:masterfrom
nxtedition:stream-end-err-cb
Closed

stream: always invoke end(cb) callback#29747
ronag wants to merge 9 commits into
nodejs:masterfrom
nxtedition:stream-end-err-cb

Conversation

@ronag

@ronagronag commented Sep 28, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Ensure that the callback passed into end() is always invoked in order to avoid bug such as deadlock the user.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-botnodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Sep 28, 2019
@ronagronag mentioned this pull request Sep 28, 2019
Closed
2 tasks
@ronag
ronagforce-pushed the stream-end-err-cb branch 4 times, most recently from 64bf430 to 9a45936CompareSeptember 28, 2019 14:19
@nodejs-github-bot

nodejs-github-bot commented Sep 28, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25753/

@nodejs-github-bot

nodejs-github-bot commented Oct 1, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25779/

@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

@nodejs/streams

mcollina
mcollina approved these changes Oct 1, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, out of precaution I would mark this semver-major.

@mcollinamcollina added the semver-major PRs that contain breaking changes and should be released in the next major version. label Oct 1, 2019
@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2022/ (queued)

@mcollina

mcollina commented Oct 2, 2019

Copy link
Copy Markdown
Member

I'm worried about https://www.npmjs.com/package/csv-parser failing on CITGM

@targos

targos commented Oct 2, 2019•
edited
Loading

Copy link
Copy Markdown
Member

csv-parser fails in all recent CITGM runs. It's not related to this change

mcollina
mcollina requested changes Oct 2, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has an interesting side effect, and I think we should try to avoid it. Calling stream.end('hello', cb) is going to prevent the error to bubble up to 'uncaughtException' if there are no other 'error' handlers.
You might want to re-emit the error if there are no other 'error' listeners.

@ronag

ronag commented Oct 2, 2019

Copy link
Copy Markdown
MemberAuthor

You might want to re-emit the error if there are no other 'error' listeners.

Excellent point. I'll take care of it.

@ronag
ronagforce-pushed the stream-end-err-cb branch 4 times, most recently from 1c093e6 to 35f00acCompareOctober 2, 2019 15:01
@ronag
ronag requested a review from mcollinaOctober 2, 2019 17:39
@Trott

Trott commented Oct 2, 2019

Copy link
Copy Markdown
Member

For anyone following along in the conversation: csv-parser should be fixed by sindresorhus/execa#370 and is indeed unrelated to these changes

@ronag
ronag requested review from jasnell and trivikrOctober 3, 2019 08:08
@ronagronag mentioned this pull request Oct 6, 2019
Closed
4 tasks
@ronag

ronag commented Oct 6, 2019

Copy link
Copy Markdown
MemberAuthor

Found another case where the callback is not called. Fixed.

mcollina
mcollina approved these changes Oct 11, 2019
View reviewed changes

@mcollinamcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot

nodejs-github-bot commented Oct 11, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25959/

@Trott

Trott commented Oct 11, 2019

Copy link
Copy Markdown
Member

Relevant test failures in test.parallel/test-stream-transform-final-sync and test.parallel/test-stream-transform-final.

@ronag

ronag commented Oct 11, 2019

Copy link
Copy Markdown
MemberAuthor

@Trott: My mistake. Should be fixed now.

@nodejs-github-bot

nodejs-github-bot commented Oct 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/25980/

@mcollina

mcollina commented Oct 15, 2019

Copy link
Copy Markdown
Member

@nodejs/tsc this needs some review

@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26043/

@nodejs-github-bot

nodejs-github-bot commented Oct 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26050/

@ronag

ronag commented Nov 11, 2019•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@Trott: This needs TSC review (see Matteo's comment)? Can we put tsc label on this or how does that work?

@Trott

Trott commented Nov 12, 2019

Copy link
Copy Markdown
Member

@Trott: This needs TSC review (see Matteo's comment)? Can we put tsc label on this or how does that work?

I think @mcollina just meant that this is semver-major so it needed a second approval from a TSC member other than him. Subsequently, @jasnell approved it, and that would be the second approval. This can land if CITGM and CI are good.

@nodejs-github-bot

nodejs-github-bot commented Nov 12, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26508/

@Trott

Trott commented Nov 12, 2019

Copy link
Copy Markdown
Member

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2089/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 12, 2019
@nodejs-github-bot

nodejs-github-bot commented Nov 15, 2019

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/26599/

addaleax pushed a commit that referenced this pull request Nov 19, 2019
@ronag@addaleax
stream: always invoke end callback
9d09969
Ensure that the callback passed into end() is always invoke in
order to avoid bug such as deadlock the user.
PR-URL: #29747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@addaleax

addaleax commented Nov 19, 2019

Copy link
Copy Markdown
Member

Landed in 9d09969

@ronagronag mentioned this pull request Dec 8, 2019
Closed
4 tasks
@ronagronag mentioned this pull request Jan 6, 2020
Closed
4 tasks
@BethGriggsBethGriggs mentioned this pull request Mar 10, 2020
Merged
@addaleaxaddaleax mentioned this pull request Mar 29, 2020
Closed
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollinamcollinamcollina approved these changes
@jasnelljasnelljasnell approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.semver-majorPRs that contain breaking changes and should be released in the next major version.streamIssues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ronag@nodejs-github-bot@Trott@mcollina@targos@addaleax@jasnell@trivikr