Skip to content

tools: update ESLint to 6.5.0 - #29759

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:eslint
Closed

tools: update ESLint to 6.5.0#29759
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:eslint

Conversation

@cjihrig

@cjihrigcjihrig commented Sep 29, 2019

Copy link
Copy Markdown
Contributor

Update ESLint to 6.5.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@cjihrig
tools: update ESLint to 6.5.0
e1dac91
Update ESLint to 6.5.0
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 29, 2019
Trott
Trott approved these changes Sep 29, 2019
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp LGTM

trivikr
trivikr approved these changes Sep 29, 2019
View reviewed changes

@trivikrtrivikr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@TrottTrott mentioned this pull request Oct 1, 2019
Closed
2 tasks
@Trott

Trott commented Oct 1, 2019

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3950/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 1, 2019
@cjihrig

cjihrig commented Oct 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@Trott please hold off on landing this one. The ESLint team just put out a patch release. I'm going to update this PR to 6.5.1.

1 similar comment
@cjihrig

cjihrig commented Oct 1, 2019

Copy link
Copy Markdown
ContributorAuthor

@Trott please hold off on landing this one. The ESLint team just put out a patch release. I'm going to update this PR to 6.5.1.

@cjihrig

cjihrig commented Oct 1, 2019

Copy link
Copy Markdown
ContributorAuthor

Nevermind. I missed #29785.

@cjihrigcjihrig closed this Oct 1, 2019
@cjihrig
cjihrig deleted the eslint branch October 1, 2019 05:39
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@trivikrtrivikrtrivikr approved these changes

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cjihrig@Trott@trivikr@nodejs-github-bot