Uh oh!
There was an error while loading. Please reload this page.
tools: update ESLint to v6.5.1 - #29785
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Trott
commented
Oct 1, 2019
MemberAuthor
cjihrig
approved these changes
Oct 1, 2019
ZYSzys
approved these changes
Oct 1, 2019
BethGriggs
approved these changes
Oct 1, 2019
BridgeAR
approved these changes
Oct 1, 2019
devnexen
approved these changes
Oct 2, 2019
Trott
commented
Oct 3, 2019
MemberAuthor
Landed in 88ef086 |
Trott added a commit
to Trott/io.js
that referenced
this pull request
Oct 3, 2019
PR-URL: nodejs#29785 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com>
BridgeAR pushed a commit
that referenced
this pull request
Oct 9, 2019
PR-URL: #29785 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: David Carlier <devnexen@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This supplants #29759 (although it can also be rebased after that one lands if we want to go that way).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes