Uh oh!
There was an error while loading. Please reload this page.
doc: add brackets to implicit markdown links - #29911
Closed
nschonni wants to merge 1 commit into
Closed
Conversation
mscdex
commented
Oct 10, 2019
Contributor
s/imlicit/implicit/ in commit message |
Trott
approved these changes
Oct 10, 2019
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM, although please do fix the typo in the commit message. Thanks!
nschonni
commented
Oct 10, 2019
MemberAuthor
@Trott is is better for the person landing it to fix it rather than retriggering the CI for the message change? |
Trott
commented
Oct 10, 2019
Member
The downside of expecting the person landing to fix it is that they might not actually do it. So it's probably slightly preferable to just do it yourself now and let CI re-run. But that's just my opinion. Others may have a different opinion, of course. |
nschonniforce-pushed
the
doc--add-brackets-to-imlicit-markdown-links
branch
from
October 10, 2019 05:48
e9bdc10 to
0f371ebComparenschonni
commented
Oct 10, 2019
MemberAuthor
OK, just rebased it |
BridgeAR
approved these changes
Oct 10, 2019
cjihrig
approved these changes
Oct 10, 2019
Trott
commented
Oct 10, 2019
Member
Trott
commented
Oct 12, 2019
Member
Landed in 88e8156 |
Trott pushed a commit
that referenced
this pull request
Oct 12, 2019
PR-URL: #29911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit
that referenced
this pull request
Oct 14, 2019
PR-URL: #29911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes