v12.13.0 'Erbium' release proposal by targos · Pull Request #29981 · nodejs/node

targos · 2019-10-15T11:39:28Z

2019-10-21, Version 12.13.0 'Erbium' (LTS), @targos

This release marks the transition of Node.js 12.x into Long Term Support (LTS)
with the codename 'Erbium'. The 12.x release line now moves into "Active LTS"
and will remain so until October 2020. After that time, it will move into
"Maintenance" until end of life in April 2022.

Notable changes

npm was updated to 6.12.0. It now includes a version of node-gyp that
supports Python 3 for building native modules.

Commits

[b59209b118] - deps: update npm to 6.12.0 (isaacs) #29885
[1dde617491] - doc: fix --enable-source-maps flag in v12.12.0 changelog (Unlocked) #29960
[e5e2dfabdc] - doc: nest code fence under unordered list (Nick Schonning) #29915
[5b0c993d4c] - doc: remove double word "where" (Nick Schonning) #29915
[ad318c6cec] - doc: add brackets to implicit markdown links (Nick Schonning) #29911
[3155ab4134] - doc: use the WHATWG URL API in http code examples (Thomas Watson) #29917
[b916ea3010] - doc: escape brackets not used as markdown reference links (Nick Schonning) #29809
[f3bf8be11c] - doc: correct typos in security release process (Nick Schonning) #29822
[25fa2066a2] - doc: indent code fence under list item (Nick Schonning) #29822
[f3842892dd] - doc: return type is number (exoego) #29828
[cbd12518d4] - doc: add note about forwarding stream options (Robert Nagy) #29857
[7683aa0bfb] - doc: set module version 72 to node 12 (Gerhard Stoebich) #29877
[f58fe5099a] - doc: fix tls version values (Tobias Nießen) #29839
[8ebc94562c] - fs: do not emit 'finish' before 'open' on write empty file (Robert Nagy) #29930
[50f066087e] - test: do not force the process to exit (Luigi Pinca) #29923
[44c581ef0b] - test: add more recursive fs.rmdir() tests (Maria Paktiti) #29815
[fc5334513c] - test: remove unnecessary --expose-internals flags (Anna Henningsen) #29886

PR-URL: #29839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Clearly state the modules version 72 is official node 12, similar as it is done for other major node versions. PR-URL: #29877 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #29886 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

It is a common and unfortunate pattern to simply just forward any and all options into the base constructor without taking into account whether these options might conflict with basic stream assumptions. PR-URL: #29857 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

PR-URL: #29828 Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #29822 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

- Double word "the" - offical -> official - annoucement -> announcement PR-URL: #29822 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

These can turn into links if reference links are added to the document PR-URL: #29809 Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #29917 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>

PR-URL: #29911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

When it isn't nested, a new unordered list is created for the next item PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Corrects "--source-map-support" to "--enable-source-maps". Fixes: #29959 PR-URL: #29960 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Update tests to create more nested folders and files, like rimraf package tests do. Each test will create 28 nested directories and 210 files. It will also create different types of files, like symlinks. PR-URL: #29815 Reviewed-By: Ben Coe <bencoe@gmail.com>

Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: #29873 (review) PR-URL: #29923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>

targos · 2019-10-15T11:48:54Z

CI: https://ci.nodejs.org/view/All/job/node-release-candidate/15/

targos · 2019-10-15T11:49:18Z

/cc @nodejs/collaborators @nodejs/tsc @nodejs/releasers

targos · 2019-10-15T11:57:35Z

Release candidate build: https://ci-release.nodejs.org/job/iojs+release/4766/

mcollina

LGTM

targos · 2019-10-15T14:53:04Z

RC available for download: https://nodejs.org/download/rc/v12.13.0-rc.0/

'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: expressjs/multer#238 PR-URL: #29930 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

This release marks the transition of Node.js 12.x into Long Term Support (LTS) with the codename 'Erbium'. The 12.x release line now moves into "Active LTS" and will remain so until October 2020. After that time, it will move into "Maintenance" until end of life in April 2022. Notable changes: npm was updated to 6.12.0. It now includes a version of `node-gyp` that supports Python 3 for building native modules. PR-URL: #29981

targos · 2019-10-18T07:16:42Z

CI: https://ci.nodejs.org/view/All/job/node-release-candidate/16/
New RC build: https://ci-release.nodejs.org/job/iojs+release/4771/

targos · 2019-10-18T08:31:35Z

https://nodejs.org/download/rc/v12.13.0-rc.1/

targos · 2019-10-18T16:02:37Z

@Trott there is a citgm-smoker run in https://ci.nodejs.org/view/All/job/node-release-candidate/16/

Trott · 2019-10-18T16:09:17Z

@Trott there is a citgm-smoker run in https://ci.nodejs.org/view/All/job/node-release-candidate/16/

Today I learned!

targos · 2019-10-18T16:13:57Z

Resumed node-test-commit: https://ci.nodejs.org/job/node-test-commit/31992/
Rebuilt node-test-commit-v8-linux: https://ci.nodejs.org/job/node-test-commit-v8-linux/2562/

Trott · 2019-10-18T16:22:26Z

Only two CITGM failures! Both are long-standing and not new here, one has a fix ready to go (just needs to land and be released in the package).

nodejs-github-bot · 2019-10-20T09:22:14Z

CI: https://ci.nodejs.org/job/node-test-pull-request/26118/

cclauss · 2019-10-20T09:26:09Z

Are we OK with the Travis failure? https://travis-ci.com/nodejs/node/jobs/247038699#L263

Trott · 2019-10-21T01:45:28Z

Are we OK with the Travis failure? https://travis-ci.com/nodejs/node/jobs/247038699#L263

Re-running the check to see if it's flaky or consistent....

richardlau · 2019-10-21T02:06:41Z

Are we OK with the Travis failure? https://travis-ci.com/nodejs/node/jobs/247038699#L263
Re-running the check to see if it's flaky or consistent....

and FWIW it failed once in the v12.12.0 release on both the CI and Travis: #29919 (comment)

targos · 2019-10-21T07:07:46Z

Release build: https://ci-release.nodejs.org/job/iojs+release/4777/

PR-URL: #29981

This release marks the transition of Node.js 12.x into Long Term Support (LTS) with the codename 'Erbium'. The 12.x release line now moves into "Active LTS" and will remain so until October 2020. After that time, it will move into "Maintenance" until end of life in April 2022. Notable changes: npm was updated to 6.12.0. It now includes a version of `node-gyp` that supports Python 3 for building native modules. PR-URL: #29981

Refs: nodejs/node#29981

Flarna · 2019-10-21T10:15:11Z

Download page on nodejs.org shows 12.13.0 LTS as Recommended For Most Users and 12.12.0 as Latest Features.
I expect 13.0.0 will be there soon...

targos · 2019-10-21T10:17:49Z

13.0.0 will be there tomorrow

tniessenand others added 15 commits October 14, 2019 17:25

doc: return type is number
f384289
PR-URL: #29828 Reviewed-By: Rich Trott <rtrott@gmail.com>

doc: escape brackets not used as markdown reference links
b916ea3
These can turn into links if reference links are added to the document PR-URL: #29809 Reviewed-By: Rich Trott <rtrott@gmail.com>

doc: add brackets to implicit markdown links
ad318c6
PR-URL: #29911 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. v12.x labels Oct 15, 2019

richardlau approved these changes Oct 15, 2019
View reviewed changes

BridgeAR approved these changes Oct 15, 2019
View reviewed changes

gengjiawen approved these changes Oct 15, 2019
View reviewed changes

cjihrig approved these changes Oct 15, 2019
View reviewed changes

hiroppy approved these changes Oct 15, 2019
View reviewed changes

gireeshpunathil approved these changes Oct 15, 2019
View reviewed changes

mcollina approved these changes Oct 15, 2019
View reviewed changes

BethGriggs approved these changes Oct 15, 2019
View reviewed changes

jasnell approved these changes Oct 15, 2019
View reviewed changes

ronagand others added 2 commits October 18, 2019 09:09

targos force-pushed the v12.13.0-proposal branch from 89c8158 to 42cce5aCompare October 18, 2019 07:15

richardlau mentioned this pull request Oct 18, 2019
Add blog post for v10 LTS to v12 LTS nodejs/nodejs.org#2701
Merged

This comment has been minimized.
Sign in to view

azu mentioned this pull request Oct 20, 2019
Node.js 12.x に変更する js-primer/js-primer#976
Closed

targos merged commit 42cce5a into v12.xOct 21, 2019

targos added a commit that referenced this pull request Oct 21, 2019
Working on v12.13.1
d9174b4
PR-URL: #29981

targos added a commit to nodejs/nodejs.org that referenced this pull request Oct 21, 2019
Blog: v12.13.0 release post
88bed24
Refs: nodejs/node#29981

targos mentioned this pull request Oct 21, 2019
Blog: v12.13.0 release post nodejs/nodejs.org#2705
Merged

targos added a commit to nodejs/nodejs.org that referenced this pull request Oct 21, 2019
Blog: v12.13.0 release post (#2705)
3f8eed8
Refs: nodejs/node#29981

targos deleted the v12.13.0-proposal branch October 21, 2019 09:26

nwtgck mentioned this pull request Oct 21, 2019
Bump node from 10.15-alpine to 12.1-alpine nwtgck/piping-server#142
Closed

arosequist mentioned this pull request Oct 22, 2019
Add Node 12 SPSCommerce/supp-docker-node-service#8
Merged

targos added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. labels Jun 6, 2021

Uh oh!

Uh oh!

Conversation

targos commented Oct 15, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2019-10-21, Version 12.13.0 'Erbium' (LTS), @targos

Notable changes

Commits

Uh oh!

targos commented Oct 15, 2019

Uh oh!

targos commented Oct 15, 2019

Uh oh!

targos commented Oct 15, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

targos commented Oct 15, 2019

Uh oh!

targos commented Oct 18, 2019

Uh oh!

targos commented Oct 18, 2019

Uh oh!

This comment has been minimized.

targos commented Oct 18, 2019

Uh oh!

Trott commented Oct 18, 2019

Uh oh!

targos commented Oct 18, 2019

Uh oh!

Trott commented Oct 18, 2019

Uh oh!

nodejs-github-bot commented Oct 20, 2019

Uh oh!

cclauss commented Oct 20, 2019

Uh oh!

Trott commented Oct 21, 2019

Uh oh!

richardlau commented Oct 21, 2019

Uh oh!

targos commented Oct 21, 2019

Uh oh!

Flarna commented Oct 21, 2019

Uh oh!

targos commented Oct 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

targos commented Oct 15, 2019•
edited
Loading