Uh oh!
There was an error while loading. Please reload this page.
doc: nest code fence under unordered list - #29915
Closed
nschonni wants to merge 2 commits into
Closed
Conversation
When it isn't nested, a new unordered list is created for the next item
Trott
approved these changes
Oct 10, 2019
BridgeAR
approved these changes
Oct 10, 2019
BridgeAR
commented
Oct 10, 2019
Member
@nschonni thank you for looking closely into the documentation formatting! |
nschonni
commented
Oct 10, 2019
MemberAuthor
No problem, just see what the gaps are between the Remark-lint preset and Markdownlint :) |
cjihrig
approved these changes
Oct 10, 2019
Trott
commented
Oct 10, 2019
Member
trivikr
approved these changes
Oct 10, 2019
lpinca
approved these changes
Oct 11, 2019
Trott pushed a commit
that referenced
this pull request
Oct 13, 2019
PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott pushed a commit
that referenced
this pull request
Oct 13, 2019
When it isn't nested, a new unordered list is created for the next item PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Oct 13, 2019
Member
Landed in 19a8d22...40ef537 |
targos pushed a commit
that referenced
this pull request
Oct 14, 2019
PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit
that referenced
this pull request
Oct 14, 2019
When it isn't nested, a new unordered list is created for the next item PR-URL: #29915 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes