Uh oh!
There was an error while loading. Please reload this page.
test: do not force the process to exit - #29923
Closed
lpinca wants to merge 1 commit into
Closed
Conversation
cjihrig
approved these changes
Oct 10, 2019
BridgeAR
approved these changes
Oct 10, 2019
richardlau
approved these changes
Oct 10, 2019
Trott
approved these changes
Oct 10, 2019
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. I'd prefer some details in the commit message, but that's not blocking. Maybe something like this?:
Using process.exit() in these tests is unnecessary and may mask other problems.
Fishrock123
approved these changes
Oct 10, 2019
devnexen
approved these changes
Oct 11, 2019
antsmartian
approved these changes
Oct 11, 2019
lpincaforce-pushed
the
remove/process-exit
branch
from
October 11, 2019 13:20
b3b9211 to
b9139a4Comparenodejs-github-bot
commented
Oct 11, 2019
Collaborator
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: nodejs#29873 (review)
lpincaforce-pushed
the
remove/process-exit
branch
from
October 11, 2019 18:46
b9139a4 to
5527329Comparelpinca
commented
Oct 11, 2019
MemberAuthor
Added a few more, PTAL. |
nodejs-github-bot
commented
Oct 11, 2019
Collaborator
ZYSzys
approved these changes
Oct 12, 2019
Trott pushed a commit
that referenced
this pull request
Oct 13, 2019
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: #29873 (review) PR-URL: #29923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Trott
commented
Oct 13, 2019
Member
Landed in 19a8d22 |
targos pushed a commit
that referenced
this pull request
Oct 14, 2019
Using `process.exit()` in these tests is unnecessary and may mask other problems. Refs: #29873 (review) PR-URL: #29923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #29873 (review)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes