fs: do not emit 'finish' before 'open' on writing empty file by ronag · Pull Request #29930 · nodejs/node

ronag · 2019-10-11T10:13:33Z

'finish' could previously be emitted before the file has been
created when ending a write stream without having written any
data.

Refs: expressjs/multer#238

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

ronag · 2019-10-11T10:46:04Z

@Trott @mcollina

mcollina · 2019-10-11T13:28:14Z

The commit has the wrong subsystem prefix. It’s not stream, but rather fs.

Trott · 2019-10-11T13:42:05Z

@nodejs/fs

Trott · 2019-10-11T13:46:05Z

The commit has the wrong subsystem prefix. It’s not stream, but rather fs.

I tried to amend the commit message but don't have permission to the nxtedition/node.git repo. But I did change the title of this PR to what I would recommend the commit message be changed to.

Trott

LGTM with commit messages/subsytem changed to fs (and assuming no CI surprises).

Will run CITGM too to make sure this fixes the multer issue and doesn't unexpectedly create issues somewhere else.

Trott · 2019-10-11T13:49:22Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2049/

'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: expressjs/multer#238

ronag · 2019-10-11T13:54:37Z

amended commit msg

mcollina

LGTM

nodejs-github-bot · 2019-10-11T13:59:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25958/

Trott · 2019-10-12T02:27:39Z

CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2049/

CITGM results look great. No multer failures anymore and no new unexpected failures.

nodejs-github-bot · 2019-10-12T03:59:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/25979/ ✔️

'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: expressjs/multer#238 PR-URL: #29930 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Trott · 2019-10-13T23:23:18Z

Landed in ba45367. Thanks!

'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: expressjs/multer#238 PR-URL: #29930 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

boneskull · 2019-10-24T20:02:53Z

It looks like this may be causing some test failures in userland: see sindresorhus/copy-file#38

https://travis-ci.org/sindresorhus/cp-file/jobs/602461047#L280

In this case, errno is undefined whereas before it was -5.

boneskull · 2019-10-24T20:23:00Z

previously the first error emitted from the fs readable stream was EIO; now it's ERR_STREAM_WRITE_AFTER_END. going to guess that's because the latter now comes out of "open" and the former out of "finish"

given this test is doing some monkeypatching in its harness, we can probably just work around that, but wanted to make sure this was intended?

ronag · 2019-10-24T20:29:16Z

@boneskull: I'm not sure I'm following. Can you provide a simple example?

boneskull · 2019-10-24T20:35:35Z

@ronag I can't really, as it's not my code and I don't really understand the intent. But I can tell you that previous to Node.js v12.13.0, the first error emitted from a writable stream in this test case was one w/ codeEIO; and now it's one with ERR_STREAM_WRITE_AFTER_END.

https://github.com/sindresorhus/cp-file/blob/master/test/async.js#L244

mcollina · 2019-10-25T08:04:23Z

@boneskull would you mind opening a new issue in this repo? Would you mind confirming that Node 12.12.0 was working as expected.

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Oct 11, 2019

This was referenced Oct 11, 2019
Race condition in test expressjs/multer#238
Closed
use 'close' event on file stream for reliability expressjs/multer#787
Closed

ronag force-pushed the fs-fix-write-stream-open-final branch from 936bd44 to c0ba9a2Compare October 11, 2019 10:19

Trott changed the title ~~stream: don't emit 'finish' before 'open' on write empty file~~fs: do not emit 'finish' before 'open' on writing empty fileOct 11, 2019

Trott approved these changes Oct 11, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2019

fs: don't emit 'finish' before 'open' on write empty file
f341a47
'finish' could previously be emitted before the file has been created when ending a write stream without having written any data. Refs: expressjs/multer#238

ronag force-pushed the fs-fix-write-stream-open-final branch from c0ba9a2 to f341a47Compare October 11, 2019 13:54

mcollina approved these changes Oct 11, 2019
View reviewed changes

Trott added this to the 13.0.0 milestone Oct 11, 2019

lpinca approved these changes Oct 11, 2019
View reviewed changes

addaleax approved these changes Oct 11, 2019
View reviewed changes

This comment has been minimized.
Sign in to view

Fishrock123 approved these changes Oct 12, 2019
View reviewed changes

Trott closed this Oct 13, 2019

Trott mentioned this pull request Oct 15, 2019
v12.13.0 'Erbium' release proposal #29981
Merged

BethGriggs mentioned this pull request Oct 21, 2019
2019-10-22, Version 13.0.0 (Current) #29504
Merged

boneskull mentioned this pull request Oct 24, 2019
Always throw if unable to overwrite sindresorhus/copy-file#38
Merged

Uh oh!

Uh oh!

Conversation

ronag commented Oct 11, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Uh oh!

ronag commented Oct 11, 2019

Uh oh!

mcollina commented Oct 11, 2019

Uh oh!

Trott commented Oct 11, 2019

Uh oh!

Trott commented Oct 11, 2019

Uh oh!

Trott left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

Trott commented Oct 11, 2019

Uh oh!

ronag commented Oct 11, 2019

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 11, 2019

Uh oh!

Trott commented Oct 12, 2019

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Oct 12, 2019• edited by Trott Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Trott commented Oct 13, 2019

Uh oh!

boneskull commented Oct 24, 2019

Uh oh!

boneskull commented Oct 24, 2019

Uh oh!

ronag commented Oct 24, 2019

Uh oh!

boneskull commented Oct 24, 2019

Uh oh!

mcollina commented Oct 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ronag commented Oct 11, 2019•
edited
Loading

nodejs-github-bot commented Oct 12, 2019•
edited by Trott
Loading