Skip to content

doc: fix --enable-source-maps flag in v12.12.0 changelog - #29960

Closed
TheUnlocked wants to merge 1 commit into
nodejs:masterfrom
TheUnlocked:patch-1
Closed

doc: fix --enable-source-maps flag in v12.12.0 changelog#29960
TheUnlocked wants to merge 1 commit into
nodejs:masterfrom
TheUnlocked:patch-1

Conversation

@TheUnlocked

@TheUnlockedTheUnlocked commented Oct 14, 2019

Copy link
Copy Markdown
Contributor

Resolves#29959

@TheUnlocked
Resolvesnodejs#29959
c3eea4c
Corrects "--source-map-support" to "--enable-source-maps"
@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 14, 2019
@Trott
Trott requested a review from bcoeOctober 14, 2019 02:07
@TrottTrott mentioned this pull request Oct 14, 2019
Merged
@BridgeARBridgeAR changed the title Correct "--source-map-support" to "--enable-source-maps" in v12.12.0 changelogdoc: fix --enable-source-maps flag in v12.12.0 changelogOct 14, 2019
@BridgeAR

BridgeAR commented Oct 14, 2019

Copy link
Copy Markdown
Member

Please upvote to fast-track.

@addaleaxaddaleax added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 14, 2019
@addaleax

addaleax commented Oct 14, 2019

Copy link
Copy Markdown
Member

Landed in c625039

addaleax pushed a commit that referenced this pull request Oct 14, 2019
@TheUnlocked@addaleax
doc: fix --enable-source-maps flag in v12.12.0 changelog
c625039
Corrects "--source-map-support" to "--enable-source-maps".
Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos pushed a commit that referenced this pull request Oct 14, 2019
@TheUnlocked@targos
doc: fix --enable-source-maps flag in v12.12.0 changelog
1dde617
Corrects "--source-map-support" to "--enable-source-maps".
Fixes: #29959
PR-URL: #29960
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@targostargos mentioned this pull request Oct 15, 2019
Merged
@addaleaxaddaleax added the source maps Issues and PRs related to source map support. label Nov 2, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@targostargostargos approved these changes
@BethGriggsBethGriggsBethGriggs approved these changes
@BridgeARBridgeARBridgeAR approved these changes
@bcoebcoeAwaiting requested review from bcoe

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.fast-trackPRs that do not need to wait for 48 hours to land.source mapsIssues and PRs related to source map support.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CHANGELOG_V12 - wrong flag listed

7 participants

@TheUnlocked@BridgeAR@addaleax@Trott@targos@BethGriggs@nodejs-github-bot