Uh oh!
There was an error while loading. Please reload this page.
doc,meta: allow Travis results for doc/comment changes - #30330
Merged
Conversation
Trott
commented
Nov 8, 2019
Uh oh!
There was an error while loading. Please reload this page.
Trott
commented
Nov 8, 2019
MemberAuthor
Ironically... Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4034/ |
gireeshpunathil
approved these changes
Nov 8, 2019
gireeshpunathil
commented
Nov 8, 2019
Member
@Trott - does this change also render |
Trott
commented
Nov 8, 2019
MemberAuthor
Possibly. We can always keep it around for a few months to see if people still find uses for it or not. And ultimately, the Build WG can decide if having it is a maintenance burden or security risk and get rid of it, or they can decide that it costs little to keep it. |
gengjiawen
approved these changes
Nov 8, 2019
Trott
commented
Nov 8, 2019
MemberAuthor
Going to @-mention @nodejs/tsc here as it seems like the right thing to do for a process change like this. |
trivikr
approved these changes
Nov 8, 2019
cjihrig
approved these changes
Nov 8, 2019
addaleax
approved these changes
Nov 8, 2019
lpinca
approved these changes
Nov 8, 2019
Trott
commented
Nov 10, 2019
MemberAuthor
Permit the use of Travis CI results for pull requests that only change documentation or comments. This also removes node-test-pull-request-lite-pipeline from the documentation. Efforts to move all CI jobs to pipelines have stalled and it's not clear that our current Jenkins admins are enthusiastic about pipelines. PR-URL: nodejs#30330 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
commented
Nov 10, 2019
MemberAuthor
Landed in e44d73f |
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2019
Permit the use of Travis CI results for pull requests that only change documentation or comments. This also removes node-test-pull-request-lite-pipeline from the documentation. Efforts to move all CI jobs to pipelines have stalled and it's not clear that our current Jenkins admins are enthusiastic about pipelines. PR-URL: #30330 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos pushed a commit
that referenced
this pull request
Dec 1, 2019
Permit the use of Travis CI results for pull requests that only change documentation or comments. This also removes node-test-pull-request-lite-pipeline from the documentation. Efforts to move all CI jobs to pipelines have stalled and it's not clear that our current Jenkins admins are enthusiastic about pipelines. PR-URL: #30330 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Closed
MylesBorins pushed a commit
that referenced
this pull request
Dec 17, 2019
Permit the use of Travis CI results for pull requests that only change documentation or comments. This also removes node-test-pull-request-lite-pipeline from the documentation. Efforts to move all CI jobs to pipelines have stalled and it's not clear that our current Jenkins admins are enthusiastic about pipelines. PR-URL: #30330 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Permit the use of Travis CI results for pull requests that only change
documentation or comments. This also removes
node-test-pull-request-lite-pipeline from the documentation. Efforts to
move all CI jobs to pipelines have stalled and it's not clear that our
current Jenkins admins are enthusiastic about pipelines.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes