Skip to content

doc: update zlib doc - #31665

Closed
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:update-zlib-docs
Closed

doc: update zlib doc#31665
jasnell wants to merge 2 commits into
nodejs:masterfrom
jasnell:update-zlib-docs

Conversation

@jasnell

@jasnelljasnell commented Feb 6, 2020

Copy link
Copy Markdown
Member

Just some general improvements to zlib docs and examples

@nodejs-github-botnodejs-github-bot added doc Issues and PRs related to the documentations. zlib Issues and PRs related to the zlib subsystem. labels Feb 6, 2020
@jasnell
jasnell requested a review from mcollinaFebruary 6, 2020 15:57
mcollina
mcollina reviewed Feb 6, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Comment threaddoc/api/zlib.md Outdated
Comment threaddoc/api/zlib.md Outdated
jasnell
jasnell commented Feb 6, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
@jasnell
jasnell requested a review from mcollinaFebruary 6, 2020 19:47
lpinca
lpinca reviewed Feb 6, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
lpinca
lpinca reviewed Feb 6, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
addaleax
addaleax reviewed Feb 6, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Comment threaddoc/api/zlib.md Outdated
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
Trott
Trott reviewed Feb 7, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
jasnell
jasnell commented Feb 17, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
@jasnell

jasnell commented Feb 17, 2020

Copy link
Copy Markdown
MemberAuthor

@Trott and @addaleax ... updated to address feedback. Please take another look :-)

@jasnell

jasnell commented Feb 24, 2020

Copy link
Copy Markdown
MemberAuthor

Ping @Trott and @addaleax

addaleax
addaleax approved these changes Feb 25, 2020
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

Comment threaddoc/api/zlib.md Outdated
jasnell
jasnell commented Feb 26, 2020
View reviewed changes
Comment threaddoc/api/zlib.md Outdated
@jasnelljasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 26, 2020
@jasnell

jasnell commented Feb 26, 2020•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4135/
First CI attempt failed...

Trying again: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4136/

@jasnell
doc: update zlib doc
919651b
Just some general improvements to zlib docs and examples
Signed-off-by: James M Snell <jasnell@gmail.com>
@nodejs-github-bot

nodejs-github-bot commented Feb 27, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/29399/

jasnell added a commit that referenced this pull request Feb 27, 2020
@jasnell
doc: update zlib doc
c6ed01c
Just some general improvements to zlib docs and examples
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

jasnell commented Feb 27, 2020

Copy link
Copy Markdown
MemberAuthor

Landed in c6ed01c

@jasnelljasnell closed this Feb 27, 2020
@Trott

Trott commented Feb 27, 2020

Copy link
Copy Markdown
Member

CI-Lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4135/
First CI attempt failed...

Trying again: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4136/

Not sure if this was kicked off for some other reason and you already are aware of this, but just in case: FYI we changed the landing rules and lite CI is generally not needed anymore if Travis passed. #30330

codebytere pushed a commit that referenced this pull request Feb 27, 2020
@jasnell@codebytere
doc: update zlib doc
e3258fd
Just some general improvements to zlib docs and examples
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Feb 29, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 15, 2020
@jasnell@codebytere
doc: update zlib doc
612a699
Just some general improvements to zlib docs and examples
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
codebytere pushed a commit that referenced this pull request Mar 17, 2020
@jasnell@codebytere
doc: update zlib doc
87fc9cb
Just some general improvements to zlib docs and examples
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@codebyterecodebytere mentioned this pull request Mar 17, 2020
Merged
codebytere pushed a commit that referenced this pull request Mar 30, 2020
@jasnell@codebytere
doc: update zlib doc
1630320
Just some general improvements to zlib docs and examples
Signed-off-by: James M Snell <jasnell@gmail.com>
PR-URL: #31665
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes
@mcollinamcollinaAwaiting requested review from mcollina

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.docIssues and PRs related to the documentations.zlibIssues and PRs related to the zlib subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@nodejs-github-bot@Trott@mcollina@addaleax@lpinca