Uh oh!
There was an error while loading. Please reload this page.
stream: sync stream unpipe resume - #31191
Closed
ronag wants to merge 4 commits into
Closed
Conversation
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190
ronag
commented
Jan 5, 2020
Uh oh!
There was an error while loading. Please reload this page.
MemberAuthor
The problem here is that we call |
addaleax
approved these changes
Jan 5, 2020
addaleax
left a comment
Member
There was a problem hiding this comment.
LGTM if CI (and linter) are green
Uh oh!
There was an error while loading. Please reload this page.
ronagforce-pushed
the
stream-readable-unpipe-resume
branch
from
January 5, 2020 11:06
801fa99 to
786fcbbCompareronagforce-pushed
the
stream-readable-unpipe-resume
branch
from
January 5, 2020 11:07
786fcbb to
c9cd445Comparenodejs-github-bot
commented
Jan 5, 2020
Collaborator
lpinca
approved these changes
Jan 6, 2020
Trott
approved these changes
Jan 6, 2020
addaleax
commented
Jan 7, 2020
Member
Landed in b9e6c1b :) |
Merged
codebytere
commented
Mar 14, 2020
Member
@ronag this looks like it'll need a manual backport to v12.x, if we think it should land there. I'll add the label but feel free to swap it! |
4 tasks
ronag
commented
Mar 14, 2020
MemberAuthor
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Apr 1, 2020
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 Backport-PR-URL: nodejs#32264 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
ronag added a commit
to nxtedition/node
that referenced
this pull request
Apr 1, 2020
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#32264
MylesBorins pushed a commit
that referenced
this pull request
Apr 1, 2020
pipe() ondata should not control flow state if cleaned up. Fixes: #31190 Backport-PR-URL: #32264 PR-URL: #31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #32264
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipe() ondata should not control flow state if cleaned up.
Fixes: #31190
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes