Uh oh!
There was an error while loading. Please reload this page.
[v12.x backport] stream: sync stream unpipe resume - #32264
Closed
ronag wants to merge 1 commit into
Closed
Conversation
ronagforce-pushed
the
backport-31191-to-12.x
branch
from
March 14, 2020 17:36
d56c5b2 to
0b1f537Compare4 tasks
nodejs-github-bot
commented
Mar 14, 2020
Collaborator
codebytere
commented
Mar 14, 2020
Member
@ronag can you also add |
ronag
commented
Mar 14, 2020
MemberAuthor
@codebytere I did? |
nodejs-github-bot
commented
Mar 20, 2020
Collaborator
nodejs-github-bot
commented
Mar 23, 2020
Collaborator
codebytereforce-pushed
the
v12.x-staging
branch
2 times, most recently
from
March 31, 2020 23:57
63a03d2 to
d577190Comparecodebytere
commented
Apr 1, 2020
Member
@ronag could you please rebase this against latest staging? |
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Apr 1, 2020
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 Backport-PR-URL: nodejs#32264 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
commented
Apr 1, 2020
Contributor
I went ahead and got a rebase done but was unable to push to the branch https://github.com/MylesBorins/node/tree/backport-31191-to-12.x |
nodejs-github-bot
commented
Apr 1, 2020
Collaborator
pipe() ondata should not control flow state if cleaned up. Fixes: nodejs#31190 PR-URL: nodejs#31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: nodejs#32264
ronagforce-pushed
the
backport-31191-to-12.x
branch
from
April 1, 2020 07:12
0b1f537 to
1cdf6f6Compareronag
commented
Apr 1, 2020
MemberAuthor
Not sure what this means. Is there a setting I missed when creating this branch? |
nodejs-github-bot
commented
Apr 1, 2020
Collaborator
nodejs-github-bot
commented
Apr 1, 2020
Collaborator
MylesBorins
commented
Apr 1, 2020
Contributor
This comes from a fork in an org not a personal repo so I don't think others can push to it. Looks like lots of failures so double checking that staging is still green 12.x-staging CI: https://ci.nodejs.org/job/node-test-commit/37126/ |
This comment has been minimized.
This comment has been minimized.
nodejs-github-bot
commented
Apr 1, 2020
Collaborator
MylesBorins
commented
Apr 1, 2020
Contributor
landed in 12253f8 |
MylesBorins pushed a commit
that referenced
this pull request
Apr 1, 2020
pipe() ondata should not control flow state if cleaned up. Fixes: #31190 Backport-PR-URL: #32264 PR-URL: #31191 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Backport-PR-URL: #32264
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #31191
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes