Skip to content

test: fix python-version selection with actions - #32609

Closed
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:actions-fixup
Closed

test: fix python-version selection with actions#32609
MylesBorins wants to merge 1 commit into
nodejs:masterfrom
MylesBorins:actions-fixup

Conversation

@MylesBorins

Copy link
Copy Markdown
Contributor

s/PYTHON_VERSION/python-version

according to official docs we have not been selecting python correctly in our actions

Refs: https://github.com/actions/setup-python

@nodejs-github-botnodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 2, 2020
addaleax pushed a commit that referenced this pull request Apr 2, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
PR-URL: #32609
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax

Copy link
Copy Markdown
Member

Landed in f36e248

@addaleaxaddaleax closed this Apr 2, 2020
BethGriggs pushed a commit that referenced this pull request Apr 7, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
PR-URL: #32609
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 12, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
PR-URL: #32609
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos mentioned this pull request Apr 13, 2020
richardlau added a commit to richardlau/node-1 that referenced this pull request May 29, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: nodejs#32609
PR-URL: nodejs#33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: #32609
PR-URL: #33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: #32609
PR-URL: #33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 8, 2020
s/PYTHON\_VERSION/python-version
Refs: https://github.com/actions/setup-python
Refs: #32609
PR-URL: #33589
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metaIssues and PRs related to the general management of the project.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@MylesBorins@addaleax@jasnell@targos@mmarchini@richardlau@ZYSzys@nodejs-github-bot